C#: Do not extractor private or internal types from reference assembl…

…ies.
github · Nov 26, 2024 · 374f398 · 374f398
1 parent 7675aa3
commit 374f398
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Analyser.cs b/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Analyser.cs
@@ -262,6 +262,9 @@ public void AnalyseCompilation()
             extractionTasks.Add(() => DoAnalyseCompilation());
         }
 
+        private static bool IsPrivateOrInternal(ISymbol symbol) =>
+            symbol.DeclaredAccessibility == Accessibility.Private || symbol.DeclaredAccessibility == Accessibility.Internal;
+
         private static void AnalyseNamespace(Context cx, INamespaceSymbol ns)
         {
             foreach (var memberNamespace in ns.GetNamespaceMembers())
@@ -271,7 +274,10 @@ private static void AnalyseNamespace(Context cx, INamespaceSymbol ns)
 
             foreach (var memberType in ns.GetTypeMembers())
             {
-                Entities.Type.Create(cx, memberType).ExtractRecursive();
+                if (!IsPrivateOrInternal(memberType))
+                {
+                    Entities.Type.Create(cx, memberType).ExtractRecursive();
+                }
             }
         }
 

diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Extractor.cs b/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Extractor.cs
@@ -549,7 +549,6 @@ private static ExitCode AnalyseTracing(
                         compilerArguments.CompilationOptions
                             .WithAssemblyIdentityComparer(DesktopAssemblyIdentityComparer.Default)
                             .WithStrongNameProvider(new DesktopStrongNameProvider(compilerArguments.KeyFileSearchPaths))
-                            .WithMetadataImportOptions(MetadataImportOptions.All)
                         );
                 },
                 (compilation, options) => analyser.EndInitialize(compilerArguments, options, compilation, cwd, args),