Skip to content

Commit cdd6245

Browse files
owen-mcowen-mc
authored
Merge pull request #19799 from owen-mc/java/quality-tags
Java: Tag quality queries with `quality` and sub-category
2 parents 036489c + 7a50298 commit cdd6245

File tree

82 files changed

+350
-106
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

82 files changed

+350
-106
lines changed

‎java/ql/integration-tests/java/query-suite/java-code-quality-extended.qls.expected

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,83 @@
1+
ql/java/ql/src/Advisory/Declarations/MissingOverrideAnnotation.ql
2+
ql/java/ql/src/Advisory/Deprecated Code/AvoidDeprecatedCallableAccess.ql
3+
ql/java/ql/src/Advisory/Documentation/ImpossibleJavadocThrows.ql
4+
ql/java/ql/src/Advisory/Documentation/SpuriousJavadocParam.ql
5+
ql/java/ql/src/Compatibility/JDK9/JdkInternalAccess.ql
6+
ql/java/ql/src/Compatibility/JDK9/UnderscoreIdentifier.ql
7+
ql/java/ql/src/DeadCode/UselessParameter.ql
18
ql/java/ql/src/Language Abuse/EmptyMethod.ql
9+
ql/java/ql/src/Language Abuse/IterableIterator.ql
210
ql/java/ql/src/Language Abuse/TypeVariableHidesType.ql
11+
ql/java/ql/src/Language Abuse/UselessNullCheck.ql
12+
ql/java/ql/src/Language Abuse/UselessTypeTest.ql
13+
ql/java/ql/src/Language Abuse/WrappedIterator.ql
14+
ql/java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
315
ql/java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql
16+
ql/java/ql/src/Likely Bugs/Arithmetic/LShiftLargerThanTypeWidth.ql
17+
ql/java/ql/src/Likely Bugs/Arithmetic/WhitespaceContradictsPrecedence.ql
18+
ql/java/ql/src/Likely Bugs/Collections/ArrayIndexOutOfBounds.ql
19+
ql/java/ql/src/Likely Bugs/Collections/ContainsTypeMismatch.ql
20+
ql/java/ql/src/Likely Bugs/Collections/ReadOnlyContainer.ql
21+
ql/java/ql/src/Likely Bugs/Collections/RemoveTypeMismatch.ql
422
ql/java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql
23+
ql/java/ql/src/Likely Bugs/Comparison/CompareIdenticalValues.ql
24+
ql/java/ql/src/Likely Bugs/Comparison/EqualsArray.ql
25+
ql/java/ql/src/Likely Bugs/Comparison/HashedButNoHash.ql
526
ql/java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql
627
ql/java/ql/src/Likely Bugs/Comparison/InconsistentEqualsHashCode.ql
728
ql/java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
829
ql/java/ql/src/Likely Bugs/Comparison/RefEqBoxed.ql
30+
ql/java/ql/src/Likely Bugs/Comparison/UselessComparisonTest.ql
31+
ql/java/ql/src/Likely Bugs/Comparison/WrongNanComparison.ql
32+
ql/java/ql/src/Likely Bugs/Concurrency/CallsToRunnableRun.ql
33+
ql/java/ql/src/Likely Bugs/Concurrency/DoubleCheckedLocking.ql
34+
ql/java/ql/src/Likely Bugs/Concurrency/DoubleCheckedLockingWithInitRace.ql
35+
ql/java/ql/src/Likely Bugs/Concurrency/NonSynchronizedOverride.ql
36+
ql/java/ql/src/Likely Bugs/Concurrency/SynchOnBoxedType.ql
37+
ql/java/ql/src/Likely Bugs/Concurrency/SynchSetUnsynchGet.ql
938
ql/java/ql/src/Likely Bugs/Frameworks/JUnit/JUnit5MissingNestedAnnotation.ql
39+
ql/java/ql/src/Likely Bugs/Inheritance/NoNonFinalInConstructor.ql
40+
ql/java/ql/src/Likely Bugs/Likely Typos/ContainerSizeCmpZero.ql
1041
ql/java/ql/src/Likely Bugs/Likely Typos/ContradictoryTypeChecks.ql
42+
ql/java/ql/src/Likely Bugs/Likely Typos/MissingFormatArg.ql
43+
ql/java/ql/src/Likely Bugs/Likely Typos/MissingSpaceTypo.ql
44+
ql/java/ql/src/Likely Bugs/Likely Typos/SelfAssignment.ql
45+
ql/java/ql/src/Likely Bugs/Likely Typos/StringBufferCharInit.ql
1146
ql/java/ql/src/Likely Bugs/Likely Typos/SuspiciousDateFormat.ql
47+
ql/java/ql/src/Likely Bugs/Likely Typos/UnusedFormatArg.ql
48+
ql/java/ql/src/Likely Bugs/Nullness/NullAlways.ql
49+
ql/java/ql/src/Likely Bugs/Nullness/NullExprDeref.ql
50+
ql/java/ql/src/Likely Bugs/Nullness/NullMaybe.ql
1251
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql
52+
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseSql.ql
1353
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseWriter.ql
54+
ql/java/ql/src/Likely Bugs/Statements/ContinueInFalseLoop.ql
55+
ql/java/ql/src/Likely Bugs/Statements/PartiallyMaskedCatch.ql
56+
ql/java/ql/src/Likely Bugs/Statements/UseBraces.ql
57+
ql/java/ql/src/Likely Bugs/Termination/ConstantLoopCondition.ql
58+
ql/java/ql/src/Performance/InefficientEmptyStringTest.ql
59+
ql/java/ql/src/Performance/InefficientKeySetIterator.ql
60+
ql/java/ql/src/Performance/InefficientOutputStream.ql
61+
ql/java/ql/src/Performance/InefficientPrimConstructor.ql
62+
ql/java/ql/src/Performance/InnerClassCouldBeStatic.ql
63+
ql/java/ql/src/Performance/NewStringString.ql
1464
ql/java/ql/src/Performance/StringReplaceAllWithNonRegex.ql
65+
ql/java/ql/src/Violations of Best Practice/Boxed Types/BoxedVariable.ql
66+
ql/java/ql/src/Violations of Best Practice/Dead Code/DeadRefTypes.ql
67+
ql/java/ql/src/Violations of Best Practice/Dead Code/InterfaceCannotBeImplemented.ql
68+
ql/java/ql/src/Violations of Best Practice/Dead Code/UnreadLocal.ql
69+
ql/java/ql/src/Violations of Best Practice/Dead Code/UnusedLabel.ql
70+
ql/java/ql/src/Violations of Best Practice/Declarations/NoConstantsOnly.ql
71+
ql/java/ql/src/Violations of Best Practice/Exception Handling/IgnoreExceptionalReturn.ql
72+
ql/java/ql/src/Violations of Best Practice/Exception Handling/NumberFormatException.ql
73+
ql/java/ql/src/Violations of Best Practice/Implementation Hiding/AbstractToConcreteCollection.ql
74+
ql/java/ql/src/Violations of Best Practice/Implementation Hiding/ExposeRepresentation.ql
75+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/AmbiguousOuterSuper.ql
76+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingMethodNames.ql
77+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql
78+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/LocalShadowsFieldConfusing.ql
79+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/SameNameAsSuper.ql
80+
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToStringToString.ql
81+
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DefaultToString.ql
1582
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DoNotCallFinalize.ql
83+
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/PrintLnArray.ql

‎java/ql/integration-tests/java/query-suite/java-code-quality.qls.expected

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,81 @@
1+
ql/java/ql/src/Advisory/Declarations/MissingOverrideAnnotation.ql
2+
ql/java/ql/src/Advisory/Deprecated Code/AvoidDeprecatedCallableAccess.ql
3+
ql/java/ql/src/Advisory/Documentation/ImpossibleJavadocThrows.ql
4+
ql/java/ql/src/Advisory/Documentation/SpuriousJavadocParam.ql
5+
ql/java/ql/src/Compatibility/JDK9/JdkInternalAccess.ql
6+
ql/java/ql/src/Compatibility/JDK9/UnderscoreIdentifier.ql
7+
ql/java/ql/src/DeadCode/UselessParameter.ql
8+
ql/java/ql/src/Language Abuse/IterableIterator.ql
9+
ql/java/ql/src/Language Abuse/UselessNullCheck.ql
10+
ql/java/ql/src/Language Abuse/UselessTypeTest.ql
11+
ql/java/ql/src/Language Abuse/WrappedIterator.ql
12+
ql/java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
113
ql/java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql
14+
ql/java/ql/src/Likely Bugs/Arithmetic/LShiftLargerThanTypeWidth.ql
15+
ql/java/ql/src/Likely Bugs/Arithmetic/WhitespaceContradictsPrecedence.ql
16+
ql/java/ql/src/Likely Bugs/Collections/ArrayIndexOutOfBounds.ql
17+
ql/java/ql/src/Likely Bugs/Collections/ContainsTypeMismatch.ql
18+
ql/java/ql/src/Likely Bugs/Collections/ReadOnlyContainer.ql
19+
ql/java/ql/src/Likely Bugs/Collections/RemoveTypeMismatch.ql
220
ql/java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql
21+
ql/java/ql/src/Likely Bugs/Comparison/CompareIdenticalValues.ql
22+
ql/java/ql/src/Likely Bugs/Comparison/EqualsArray.ql
23+
ql/java/ql/src/Likely Bugs/Comparison/HashedButNoHash.ql
324
ql/java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql
425
ql/java/ql/src/Likely Bugs/Comparison/InconsistentEqualsHashCode.ql
526
ql/java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
627
ql/java/ql/src/Likely Bugs/Comparison/RefEqBoxed.ql
28+
ql/java/ql/src/Likely Bugs/Comparison/UselessComparisonTest.ql
29+
ql/java/ql/src/Likely Bugs/Comparison/WrongNanComparison.ql
30+
ql/java/ql/src/Likely Bugs/Concurrency/CallsToRunnableRun.ql
31+
ql/java/ql/src/Likely Bugs/Concurrency/DoubleCheckedLocking.ql
32+
ql/java/ql/src/Likely Bugs/Concurrency/DoubleCheckedLockingWithInitRace.ql
33+
ql/java/ql/src/Likely Bugs/Concurrency/NonSynchronizedOverride.ql
34+
ql/java/ql/src/Likely Bugs/Concurrency/SynchOnBoxedType.ql
35+
ql/java/ql/src/Likely Bugs/Concurrency/SynchSetUnsynchGet.ql
736
ql/java/ql/src/Likely Bugs/Frameworks/JUnit/JUnit5MissingNestedAnnotation.ql
37+
ql/java/ql/src/Likely Bugs/Inheritance/NoNonFinalInConstructor.ql
38+
ql/java/ql/src/Likely Bugs/Likely Typos/ContainerSizeCmpZero.ql
839
ql/java/ql/src/Likely Bugs/Likely Typos/ContradictoryTypeChecks.ql
40+
ql/java/ql/src/Likely Bugs/Likely Typos/MissingFormatArg.ql
41+
ql/java/ql/src/Likely Bugs/Likely Typos/MissingSpaceTypo.ql
42+
ql/java/ql/src/Likely Bugs/Likely Typos/SelfAssignment.ql
43+
ql/java/ql/src/Likely Bugs/Likely Typos/StringBufferCharInit.ql
944
ql/java/ql/src/Likely Bugs/Likely Typos/SuspiciousDateFormat.ql
45+
ql/java/ql/src/Likely Bugs/Likely Typos/UnusedFormatArg.ql
46+
ql/java/ql/src/Likely Bugs/Nullness/NullAlways.ql
47+
ql/java/ql/src/Likely Bugs/Nullness/NullExprDeref.ql
48+
ql/java/ql/src/Likely Bugs/Nullness/NullMaybe.ql
1049
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql
50+
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseSql.ql
1151
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseWriter.ql
52+
ql/java/ql/src/Likely Bugs/Statements/ContinueInFalseLoop.ql
53+
ql/java/ql/src/Likely Bugs/Statements/PartiallyMaskedCatch.ql
54+
ql/java/ql/src/Likely Bugs/Statements/UseBraces.ql
55+
ql/java/ql/src/Likely Bugs/Termination/ConstantLoopCondition.ql
56+
ql/java/ql/src/Performance/InefficientEmptyStringTest.ql
57+
ql/java/ql/src/Performance/InefficientKeySetIterator.ql
58+
ql/java/ql/src/Performance/InefficientOutputStream.ql
59+
ql/java/ql/src/Performance/InefficientPrimConstructor.ql
60+
ql/java/ql/src/Performance/InnerClassCouldBeStatic.ql
61+
ql/java/ql/src/Performance/NewStringString.ql
1262
ql/java/ql/src/Performance/StringReplaceAllWithNonRegex.ql
63+
ql/java/ql/src/Violations of Best Practice/Boxed Types/BoxedVariable.ql
64+
ql/java/ql/src/Violations of Best Practice/Dead Code/DeadRefTypes.ql
65+
ql/java/ql/src/Violations of Best Practice/Dead Code/InterfaceCannotBeImplemented.ql
66+
ql/java/ql/src/Violations of Best Practice/Dead Code/UnreadLocal.ql
67+
ql/java/ql/src/Violations of Best Practice/Dead Code/UnusedLabel.ql
68+
ql/java/ql/src/Violations of Best Practice/Declarations/NoConstantsOnly.ql
69+
ql/java/ql/src/Violations of Best Practice/Exception Handling/IgnoreExceptionalReturn.ql
70+
ql/java/ql/src/Violations of Best Practice/Exception Handling/NumberFormatException.ql
71+
ql/java/ql/src/Violations of Best Practice/Implementation Hiding/AbstractToConcreteCollection.ql
72+
ql/java/ql/src/Violations of Best Practice/Implementation Hiding/ExposeRepresentation.ql
73+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/AmbiguousOuterSuper.ql
74+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingMethodNames.ql
75+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql
76+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/LocalShadowsFieldConfusing.ql
77+
ql/java/ql/src/Violations of Best Practice/Naming Conventions/SameNameAsSuper.ql
78+
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToStringToString.ql
79+
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DefaultToString.ql
1380
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DoNotCallFinalize.ql
81+
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/PrintLnArray.ql

‎java/ql/src/Advisory/Declarations/MissingOverrideAnnotation.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
* @problem.severity recommendation
77
* @precision high
88
* @id java/missing-override-annotation
9-
* @tags maintainability
9+
* @tags quality
10+
* maintainability
11+
* readability
1012
*/
1113

1214
import java

‎java/ql/src/Advisory/Deprecated Code/AvoidDeprecatedCallableAccess.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
* @problem.severity recommendation
77
* @precision high
88
* @id java/deprecated-call
9-
* @tags maintainability
9+
* @tags quality
10+
* maintainability
11+
* readability
1012
* non-attributable
1113
* external/cwe/cwe-477
1214
*/

‎java/ql/src/Advisory/Documentation/ImpossibleJavadocThrows.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
* @problem.severity recommendation
77
* @precision high
88
* @id java/inconsistent-javadoc-throws
9-
* @tags maintainability
9+
* @tags quality
10+
* maintainability
11+
* readability
1012
*/
1113

1214
import java

‎java/ql/src/Advisory/Documentation/SpuriousJavadocParam.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
* @problem.severity recommendation
77
* @precision very-high
88
* @id java/unknown-javadoc-parameter
9-
* @tags maintainability
9+
* @tags quality
10+
* maintainability
11+
* readability
1012
*/
1113

1214
import java

‎java/ql/src/Compatibility/JDK9/JdkInternalAccess.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
* @problem.severity recommendation
77
* @precision high
88
* @id java/jdk-internal-api-access
9-
* @tags maintainability
9+
* @tags quality
10+
* maintainability
11+
* readability
1012
*/
1113

1214
import java

‎java/ql/src/Compatibility/JDK9/UnderscoreIdentifier.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
* @problem.severity recommendation
77
* @precision high
88
* @id java/underscore-identifier
9-
* @tags maintainability
9+
* @tags quality
10+
* maintainability
11+
* readability
1012
*/
1113

1214
import java

‎java/ql/src/DeadCode/UselessParameter.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
* @problem.severity recommendation
66
* @precision high
77
* @id java/unused-parameter
8-
* @tags maintainability
8+
* @tags quality
9+
* maintainability
910
* useless-code
1011
* external/cwe/cwe-561
1112
*/

‎java/ql/src/Language Abuse/ChainedInstanceof.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* @precision high
77
* @id java/chained-type-tests
88
* @tags maintainability
9+
* complexity
910
* language-features
1011
*/
1112

‎java/ql/src/Language Abuse/IterableIterator.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@
77
* @problem.severity warning
88
* @precision very-high
99
* @id java/iterator-implements-iterable
10-
* @tags correctness
10+
* @tags quality
1111
* reliability
12+
* correctness
1213
*/
1314

1415
import java

‎java/ql/src/Language Abuse/UselessNullCheck.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
* @problem.severity warning
77
* @precision very-high
88
* @id java/useless-null-check
9-
* @tags maintainability
9+
* @tags quality
10+
* maintainability
1011
* useless-code
1112
* external/cwe/cwe-561
1213
*/

‎java/ql/src/Language Abuse/UselessTypeTest.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
* @problem.severity warning
66
* @precision very-high
77
* @id java/useless-type-test
8-
* @tags maintainability
8+
* @tags quality
9+
* maintainability
10+
* useless-code
911
* language-features
1012
* external/cwe/cwe-561
1113
*/

‎java/ql/src/Language Abuse/WrappedIterator.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66
* @problem.severity warning
77
* @precision very-high
88
* @id java/iterable-wraps-iterator
9-
* @tags correctness
9+
* @tags quality
1010
* reliability
11+
* correctness
1112
*/
1213

1314
import java

‎java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
* @problem.severity warning
66
* @precision very-high
77
* @id java/evaluation-to-constant
8-
* @tags maintainability
9-
* useless-code
8+
* @tags quality
9+
* reliability
10+
* correctness
1011
*/
1112

1213
import java

‎java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
* @problem.severity warning
77
* @precision very-high
88
* @id java/integer-multiplication-cast-to-long
9-
* @tags reliability
9+
* @tags quality
10+
* reliability
1011
* correctness
1112
* types
12-
* quality
1313
* external/cwe/cwe-190
1414
* external/cwe/cwe-192
1515
* external/cwe/cwe-197

‎java/ql/src/Likely Bugs/Arithmetic/LShiftLargerThanTypeWidth.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
* @problem.severity warning
66
* @precision very-high
77
* @id java/lshift-larger-than-type-width
8-
* @tags correctness
8+
* @tags quality
9+
* reliability
10+
* correctness
911
*/
1012

1113
import java

‎java/ql/src/Likely Bugs/Arithmetic/WhitespaceContradictsPrecedence.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66
* @problem.severity warning
77
* @precision very-high
88
* @id java/whitespace-contradicts-precedence
9-
* @tags maintainability
10-
* readability
9+
* @tags quality
10+
* reliability
11+
* correctness
1112
* external/cwe/cwe-783
1213
*/
1314

‎java/ql/src/Likely Bugs/Collections/ArrayIndexOutOfBounds.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
* @problem.severity error
77
* @precision high
88
* @id java/index-out-of-bounds
9-
* @tags reliability
9+
* @tags quality
10+
* reliability
1011
* correctness
1112
* exceptions
1213
* external/cwe/cwe-193

‎java/ql/src/Likely Bugs/Collections/ContainsTypeMismatch.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
* @problem.severity error
88
* @precision very-high
99
* @id java/type-mismatch-access
10-
* @tags reliability
10+
* @tags quality
11+
* reliability
1112
* correctness
1213
* logic
1314
*/

‎java/ql/src/Likely Bugs/Collections/ReadOnlyContainer.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
* @problem.severity error
66
* @precision very-high
77
* @id java/empty-container
8-
* @tags reliability
9-
* maintainability
10-
* useless-code
8+
* @tags quality
9+
* reliability
10+
* correctness
1111
* external/cwe/cwe-561
1212
*/
1313

‎java/ql/src/Likely Bugs/Collections/RemoveTypeMismatch.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
* @problem.severity error
88
* @precision very-high
99
* @id java/type-mismatch-modification
10-
* @tags reliability
10+
* @tags quality
11+
* reliability
1112
* correctness
1213
* logic
1314
*/

‎java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
* @problem.severity error
66
* @precision very-high
77
* @id java/unused-container
8-
* @tags maintainability
8+
* @tags quality
9+
* maintainability
910
* useless-code
10-
* quality
1111
* external/cwe/cwe-561
1212
*/
1313

0 commit comments

Comments
 (0)