@@ -31,7 +31,7 @@ Function getASuperCallTargetFromCall(
31
31
)
32
32
}
33
33
34
- /** Gets the method called by `meth` named `name` with `call`, with `mroBase` as the type determining the MRO to search. */
34
+ /** Gets the method called by `meth` named `name` with `call`, with `mroBase` as the type determining the MRO to search. */
35
35
Function getDirectSuperCallTargetFromCall (
36
36
Class mroBase , Function meth , DataFlow:: MethodCallNode call , string name
37
37
) {
@@ -54,7 +54,7 @@ Function getDirectSuperCallTargetFromCall(
54
54
)
55
55
}
56
56
57
- /** Gets a method that is transitively called by a call to `cls.<name>`, with `mroBase` as the type determining the MRO to search. */
57
+ /** Gets a method that is transitively called by a call to `cls.<name>`, with `mroBase` as the type determining the MRO to search. */
58
58
Function getASuperCallTargetFromClass ( Class mroBase , Class cls , string name ) {
59
59
exists ( Function target |
60
60
target = findFunctionAccordingToMroKnownStartingClass ( cls , mroBase , name ) and
@@ -79,7 +79,7 @@ predicate nonTrivial(Function meth) {
79
79
exists ( meth .getANormalExit ( ) ) // doesn't always raise an exception
80
80
}
81
81
82
- /** Holds if `call` is a call to `super().<name>`. No distinction is made btween 0- and 2- arg super calls. */
82
+ /** Holds if `call` is a call to `super().<name>`. No distinction is made between 0- and 2- arg super calls. */
83
83
predicate superCall ( DataFlow:: MethodCallNode call , string name ) {
84
84
exists ( DataFlow:: Node sup |
85
85
call .calls ( sup , name ) and
@@ -127,8 +127,9 @@ predicate missingCallToSuperclassMethod(Class base, Function shouldCall, string
127
127
not callsMethodOnUnknownClassWithSelf ( getASuperCallTargetFromClass ( base , base , name ) , name )
128
128
}
129
129
130
- /** Holds if `base` does not call a superclass method `shouldCall` named `name` when it appears it should.
131
- * Results are restricted to hold only for the highest `base` class and the lowest `shouldCall` method in the heirarchy for which this applies.
130
+ /**
131
+ * Holds if `base` does not call a superclass method `shouldCall` named `name` when it appears it should.
132
+ * Results are restricted to hold only for the highest `base` class and the lowest `shouldCall` method in the hierarchy for which this applies.
132
133
*/
133
134
predicate missingCallToSuperclassMethodRestricted ( Class base , Function shouldCall , string name ) {
134
135
missingCallToSuperclassMethod ( base , shouldCall , name ) and
@@ -144,11 +145,11 @@ predicate missingCallToSuperclassMethodRestricted(Class base, Function shouldCal
144
145
)
145
146
}
146
147
147
- /**
148
- * If `base` contains a `super()` call, gets a method in the inheritence heirarchy of `name` in the MRO of `base`
148
+ /**
149
+ * If `base` contains a `super()` call, gets a method in the inheritance hierarchy of `name` in the MRO of `base`
149
150
* that does not contain a `super()` call, but would call `shouldCall` if it did, which does not otherwise get called
150
- * during a call to `base.<name>`.
151
- * * /
151
+ * during a call to `base.<name>`.
152
+ */
152
153
Function getPossibleMissingSuper ( Class base , Function shouldCall , string name ) {
153
154
missingCallToSuperclassMethod ( base , shouldCall , name ) and
154
155
exists ( Function baseMethod |
0 commit comments