Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align danger alert to match the markdown notation #35435

Closed
1 task done
akordowski opened this issue Nov 26, 2024 · 2 comments · Fixed by #35443
Closed
1 task done

Align danger alert to match the markdown notation #35435

akordowski opened this issue Nov 26, 2024 · 2 comments · Fixed by #35443
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise

Comments

@akordowski
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

Multiple articles.

What part(s) of the article would you like to see updated?

The articles

are using the \data\reusables\enterprise_clustering\proxy_xff_firewall_warning.md reusable to display the following alert:

grafik

and the article

has the following alert:

grafik

I would suggest to use the > [!CAUTION] markdown notation to align this alerts with other alerts (also as described here).

grafik

Additional information

I could provide a PR with a fix.
@akordowski akordowski added the content This issue or pull request belongs to the Docs Content team label Nov 26, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 26, 2024
@nguyenalex836 nguyenalex836 added enterprise Content relating to GitHub Enterprise and removed triage Do not begin working on this issue until triaged by the team labels Nov 26, 2024
@nguyenalex836
Copy link
Contributor

@akordowski I'm in agreement with you 💛 Feel free to open a PR whenever you have time!

@akordowski akordowski mentioned this issue Nov 27, 2024
Merged
3 tasks
@akordowski
Copy link
Contributor Author

@nguyenalex836 Here you can see the changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix danger alert akordowski/github-docs
2 participants
@akordowski @nguyenalex836