Skip to content

Commit 737cee6

Browse files
authored
Merge pull request #122 from github/set-correct-meta-info-on-rules
Add info into the `meta` property of rules
2 parents 25c29a0 + bc687f5 commit 737cee6

17 files changed

+124
-32
lines changed

lib/rules/array-foreach.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
module.exports = {
22
meta: {
3-
docs: {},
3+
type: 'suggestion',
4+
docs: {
5+
description: 'enforce `for..of` loops over `Array.forEach`',
6+
url: require('../url')(module)
7+
},
48
schema: []
59
},
610

lib/rules/async-currenttarget.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
module.exports = {
22
meta: {
3-
docs: {},
3+
type: 'problem',
4+
docs: {
5+
description: 'disallow `event.currentTarget` calls inside of async functions',
6+
url: require('../url')(module)
7+
},
48
schema: []
59
},
610

lib/rules/async-preventdefault.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
module.exports = {
22
meta: {
3-
docs: {},
3+
type: 'problem',
4+
docs: {
5+
description: 'disallow `event.preventDefault` calls inside of async functions',
6+
url: require('../url')(module)
7+
},
48
schema: []
59
},
610

lib/rules/authenticity-token.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
module.exports = {
22
meta: {
3-
docs: {},
3+
type: 'problem',
4+
docs: {
5+
description: 'disallow usage of CSRF tokens in JavaScript',
6+
url: require('../url')(module)
7+
},
48
schema: []
59
},
610

lib/rules/get-attribute.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,13 @@ function isValidAttribute(name) {
1919

2020
module.exports = {
2121
meta: {
22-
fixable: 'code'
22+
type: 'problem',
23+
docs: {
24+
description: 'disallow wrong usage of attribute names',
25+
url: require('../url')(module)
26+
},
27+
fixable: 'code',
28+
schema: []
2329
},
2430
create(context) {
2531
return {

lib/rules/js-class-name.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
module.exports = {
22
meta: {
3-
docs: {},
3+
type: 'suggestion',
4+
docs: {
5+
description: 'enforce a naming convention for js- prefixed classes',
6+
url: require('../url')(module)
7+
},
48
schema: []
59
},
610

lib/rules/no-blur.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,17 @@
11
module.exports = function (context) {
22
return {
3+
meta: {
4+
type: 'problem',
5+
docs: {
6+
description: 'disallow usage of `Element.prototype.blur()`',
7+
url: require('../url')(module)
8+
},
9+
schema: []
10+
},
311
CallExpression(node) {
412
if (node.callee.property && node.callee.property.name === 'blur') {
513
context.report(node, 'Do not use element.blur(), instead restore the focus of a previous element.')
614
}
715
}
816
}
917
}
10-
11-
module.exports.schema = []

lib/rules/no-d-none.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
11
module.exports = {
2+
meta: {
3+
type: 'problem',
4+
docs: {
5+
description: 'disallow usage the `d-none` CSS class',
6+
url: require('../url')(module)
7+
},
8+
schema: []
9+
},
210
create(context) {
311
return {
412
CallExpression(node) {

lib/rules/no-dataset.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
module.exports = {
22
meta: {
3-
docs: {},
3+
type: 'problem',
4+
docs: {
5+
description: 'enforce usage of `Element.prototype.getAttribute` instead of `Element.prototype.datalist`',
6+
url: require('../url')(module)
7+
},
48
schema: []
59
},
610

lib/rules/no-implicit-buggy-globals.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
module.exports = {
22
meta: {
3-
docs: {},
3+
type: 'problem',
4+
docs: {
5+
description: 'disallow implicit global variables',
6+
url: require('../url')(module)
7+
},
48
schema: []
59
},
610

0 commit comments

Comments
 (0)