Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average of 16 diameters profile plot has a strange tail (lower value) for the last value on the right side of the profile #168

Open
githubdoe opened this issue Nov 5, 2024 · 1 comment

Comments

@githubdoe
Copy link
Owner

Create a simulated wave front with 0 SA. Select the 16 diameters button. The very last value is too small. I suspect the code has a bug that causes it not to add that last diameter (or some diameter) to the sum of all diameters.

I will work on it. I discovered it while working on the percent complete feature and creating spheres for debugging purposes of that feature.
profileavgerror

@githubdoe
Copy link
Owner Author

Because the surface is a matrix of pixels some diameters have more pixels than others inside the outline. Thus you can not use 16 as the divisor. Instead build a map to count how many pixels of each diameter have been used.

That works well and has now been tested. Eventually will add it to dalework. branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant