Skip to content

Fix skipping build command #57

Open
@yi-jiayu

Description

@yi-jiayu

When run with -build='', the following error occurs:

2021/01/10 16:51:52 Running build command!
2021/01/10 16:51:52 Error while building:

The following code in the build() function seems to be for conditionally skipping the build command:

CompileDaemon/daemon.go

Lines 151 to 158 in 39b144a

func build() bool {
log.Println(okColor("Running build command!"))
args := strings.Split(*flagBuild, " ")
if len(args) == 0 {
// If the user has specified and empty then we are done.
return true
}

However, the return value of strings.Split will never have length 0 because the provided separator is not empty. If provided an empty string, it will still return a slice containing a single empty string:

If s does not contain sep and sep is not empty, Split returns a slice of length 1 whose only element is s.

If sep is empty, Split splits after each UTF-8 sequence. If both s and sep are empty, Split returns an empty slice.

Maybe the condition could be replaced with if *flagBuild == "" and checked before the call to strings.Split:

 	if *flagBuild == "" { 
 		// If the value of flagBuild is empty then we are done. 
 		return true 
 	} 
 	args := strings.Split(*flagBuild, " ") 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions