Skip to content

Commit dcd9a00

Browse files
authored
Check cargo sort in make check (#2572)
This is run in CI, so running this offline avoids an unnecessary CI failure.
1 parent ad32993 commit dcd9a00

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111
* support loading custom syntax highlighting themes from a file [[@acuteenvy](https://github.com/acuteenvy)] ([#2565](https://github.com/gitui-org/gitui/pull/2565))
1212
* Select syntax highlighting theme out of the defaults from syntect [[@vasilismanol](https://github.com/vasilismanol)] ([#1931](https://github.com/extrawurst/gitui/issues/1931))
1313
* new command-line option to override the default log file path (`--logfile`) [[@acuteenvy](https://github.com/acuteenvy)] ([#2539](https://github.com/gitui-org/gitui/pull/2539))
14+
* dx: `make check` checks Cargo.toml dependency ordering using `cargo sort` [[@naseschwarz](https://github.com/naseschwarz)]
1415

1516
### Changed
1617
* improve syntax highlighting file detection [[@acuteenvy](https://github.com/acuteenvy)] ([#2524](https://github.com/extrawurst/gitui/pull/2524))

Makefile

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
.PHONY: debug build-release release-linux-musl test clippy clippy-pedantic install install-debug
2+
.PHONY: debug build-release release-linux-musl test clippy clippy-pedantic install install-debug sort
33

44
ARGS=-l
55
# ARGS=-l -d ~/code/extern/kubernetes
@@ -94,7 +94,7 @@ clippy:
9494
clippy-nightly:
9595
cargo +nightly clippy --workspace --all-features
9696

97-
check: fmt clippy test deny
97+
check: fmt clippy test deny sort
9898

9999
check-nightly:
100100
cargo +nightly c
@@ -104,6 +104,9 @@ check-nightly:
104104
deny:
105105
cargo deny check
106106

107+
sort:
108+
cargo sort -c -w "."
109+
107110
install:
108111
cargo install --path "." --offline --locked
109112

0 commit comments

Comments
 (0)