Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Safari support #1633

Open
ethanuppal opened this issue Sep 2, 2024 · 5 comments
Open

[Feature Request] Safari support #1633

ethanuppal opened this issue Sep 2, 2024 · 5 comments

Comments

@ethanuppal
Copy link

Bump on #42 (from over 5 years ago). The creator has stated they were planning to support Safari (although it was last on their todo list); I was wondering if there were any updates on this.

@glacambre
Copy link
Owner

glacambre commented Sep 3, 2024

I think Firenvim would need to be ported to manifest v3 ( #1193 ) first. This is still planned, but I just haven't gotten around to doing it (and this is getting increasingly urgent, with Chrome's depecration of manifest v2 extensions having already happened). Porting to manifest v3 might mean losing support for fancy JS editors such as Ace, CodeMirror and others.

Once the port to manifest v3 is done, it should be pretty easy to port to Safari, the only concern being that Safari is currently missing support for onCommand.tab, meaning that browser keyboard shortcuts to manually start Firenvim or to capture <C-n>, <C-t> or <C-w> will not work. Not a big deal.

Testing might be the hardest part. The current testsuite was really painful to write. Selenium does seem to support safari (and vice-versa), but I don't see if there's a way to get Safari to load an extension with Selenium. Given that I still do not have any apple devices, this means thousands of iterations with Github's mac CIs, which is going to be very painful.

Finally there'll be the $100/year I'll need to pay Apple to get the privilege of uploading a free extension to their extension store. Not sure how I feel about this.

So all in all, this is technically possible, but rather unlikely to happen anytime soon given the amount of work it will require from me. But I'd be happy to merge PRs :)

@ethanuppal
Copy link
Author

I'd be happy to test if someone wants their PR tested.

@rygwdn
Copy link

rygwdn commented Sep 4, 2024

I would be happy to help with testing, etc. as well once the move to v3 is done. It's also pretty common for open source browser plugins to be paid on the App Store to help support the cost of the developer account

@ethanuppal
Copy link
Author

Maybe you can setup a yearly income stream of $100 via e.g. Patreon?

@glacambre
Copy link
Owner

Sure, once the port is done I'll think about possibly getting users to fund the apple extension store fee. But as I said, this is the last thing to worry about - a lot of work has to happen first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants