Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git command for "hg copy"? #97

Open
timdream opened this issue Nov 28, 2016 · 4 comments
Open

git command for "hg copy"? #97

timdream opened this issue Nov 28, 2016 · 4 comments
Labels
ux User experience

Comments

@timdream
Copy link

From time to time I see reviewer asks people to "use hg copy" to preserve file copying history. I wonder how do to that if we are using git-cinnabar & git-mozreview locally?

@glandium
Copy link
Owner

For now, you can do that in two steps: write a patch that moves the file (and change the corresponding build system stuff), and a second patch that does changes after that.

@glandium
Copy link
Owner

Also note this is related to issue #10.

@ayg
Copy link

ayg commented Apr 19, 2017

The workaround doesn't work if the new file isn't functional in the new location, e.g., porting a test between .html and .xul or from mochitest to wpt. It would be desirable to preserve the history in these cases, and reviewers might reasonably insist on it. It also makes the diff more readable.

@ayg
Copy link

ayg commented Apr 19, 2017

The workaround I used that actually worked is to just import into an hg repo. :( Fortunately I do know enough basic hg commands to import a patch from git and submit it to MozReview.

@glandium glandium added the ux User experience label Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience
Projects
None yet
Development

No branches or pull requests

3 participants