From 5ba7ddb8924447f1c1953608838bfc65b44f0319 Mon Sep 17 00:00:00 2001
From: Michael Benford <michael@michaelbenford.net>
Date: Fri, 5 Jan 2018 18:58:29 -0200
Subject: [PATCH] Handle certain status codes as errors

---
 lib/Response.js       |  4 +++-
 test/Response.test.js | 40 ++++++++++++++++++++--------------------
 2 files changed, 23 insertions(+), 21 deletions(-)

diff --git a/lib/Response.js b/lib/Response.js
index 658d431..da5ddd9 100644
--- a/lib/Response.js
+++ b/lib/Response.js
@@ -1,5 +1,7 @@
 function emitError(response, statusCode, error) {
-  response.status(statusCode).send({ error });
+  const err = new Error(error);
+  err.statusCode = statusCode;
+  response.callback(err);
 }
 
 class Response {
diff --git a/test/Response.test.js b/test/Response.test.js
index aaad64d..0769614 100644
--- a/test/Response.test.js
+++ b/test/Response.test.js
@@ -65,11 +65,11 @@ describe('Response', () => {
 
   describe('create a response with bad request status code (400)', () => {
     let res;
-    let codeResponse;
+    let error;
 
     before((done) => {
-      const callback = (err, responseData) => {
-        codeResponse = responseData;
+      const callback = (err) => {
+        error = err;
         done();
       };
       res = new Response({ callback });
@@ -77,18 +77,18 @@ describe('Response', () => {
     });
 
     it('should sends the response with status of 304', () => {
-      expect(codeResponse.body).to.be.eql({ error: 'Its an error' });
-      expect(codeResponse.status).to.be.eql(400);
+      expect(error.message).to.be.eql('Its an error');
+      expect(error.statusCode).to.be.eql(400);
     });
   });
 
   describe('create a response with not found status code (404)', () => {
     let res;
-    let codeResponse;
+    let error;
 
     before((done) => {
-      const callback = (err, responseData) => {
-        codeResponse = responseData;
+      const callback = (err) => {
+        error = err;
         done();
       };
       res = new Response({ callback });
@@ -96,18 +96,18 @@ describe('Response', () => {
     });
 
     it('should sends the response with status of 404', () => {
-      expect(codeResponse.body).to.be.eql({ error: 'My resource not is found' });
-      expect(codeResponse.status).to.be.eql(404);
+      expect(error.message).to.be.eql('My resource not is found');
+      expect(error.statusCode).to.be.eql(404);
     });
   });
 
   describe('create a response with validation error status code (422)', () => {
     let res;
-    let codeResponse;
+    let error;
 
     before((done) => {
-      const callback = (err, responseData) => {
-        codeResponse = responseData;
+      const callback = (err) => {
+        error = err;
         done();
       };
       res = new Response({ callback });
@@ -115,18 +115,18 @@ describe('Response', () => {
     });
 
     it('should sends the response with status of 422', () => {
-      expect(codeResponse.body).to.be.eql({ error: 'Field a is wrong' });
-      expect(codeResponse.status).to.be.eql(422);
+      expect(error.message).to.be.eql('Field a is wrong');
+      expect(error.statusCode).to.be.eql(422);
     });
   });
 
   describe('create a response with internal server error status code (500)', () => {
     let res;
-    let codeResponse;
+    let error;
 
     before((done) => {
-      const callback = (err, responseData) => {
-        codeResponse = responseData;
+      const callback = (err) => {
+        error = err;
         done();
       };
       res = new Response({ callback });
@@ -134,8 +134,8 @@ describe('Response', () => {
     });
 
     it('should sends the response with status of 500', () => {
-      expect(codeResponse.body).to.be.eql({ error: 'Server crashed' });
-      expect(codeResponse.status).to.be.eql(500);
+      expect(error.message).to.be.eql('Server crashed');
+      expect(error.statusCode).to.be.eql(500);
     });
   });