-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation containment hierarchy #1253
Comments
Hi @BartBruininks , Please link the paper corresponding to this analysis method once its either published or on ArXiV. I would like to understand this a bit better before deciding on whether to accept a PR for it. For now, I have some questions about the analysis method, maybe you can answer them:
Lastly, the implementation seems nontrivial, so be aware that you will probably need to implement this into freud yourself if we decide to accept a PR. The freud maintainers are graduate students who have our own science projects to work on, and without the research need from one of us, the work will need to be done by someone else. |
Hi @tommy-waltmann, Once I have the paper done I will link it. Regarding your questions.
For now I do not want you to implement it for me, but I had to choose in the comment. My main goal at first would be to have a zoom presentation or something like that with the people in your team and give a presentation on the topic. I am sure people in you team will have all kinds of questions and ideas of what it can be used for. I do not mind working on the implementation if we decide it is worth it (or collaborate). As it is not yet published we could even add more contributors on the manuscript. I just have a strong feeling you will like this. Cheers, Bart |
Description
When working with point clouds or voxel densities, it is often useful to ask for the content of a component. However, the definition of inside is not trivial in periodic space. Nevertheless, having access to the output of a connected components segmentation in a directed acyclic graph can be extremely useful and indeed is possible (think of it as the folder structure of the simulation box).
Proposed Solution
I have been working on a mathematical robust classification for this problem in ND-(periodic) space. This works for any density structure in a (periodic) box, even if the densities are periodic themselves.
The implementation has been done and is on its way to being published, however, my own implementation in python is rather slow. I tried to make a version which uses Freud which works reasonably well, but I feel like a proper implementation could be a real boon for Freud.
I would love to give a (open) presentation for the developers and fellow freudians, to present my work and how I think it could be valuable to Freud --- an hour should be fine.
Additional Context
An example of what I mean is given in my Github. The implementation of the math is cheating a bit in its current implementation, but the results for the examples are all correct (I am currently reworking the code to adhere to the new mathematical machinery used to tackle the problem).
An example of a solvent phase (-2) whith multiple lipid components (1--4) in it. One of the lipid components (3) has a solvent component (-1) in its interiour as represented by the graph (the arrows point from container -->containee).
Developer
Would someone else please implement this?
The text was updated successfully, but these errors were encountered: