Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples in documentation #47

Open
bdice opened this issue Sep 19, 2019 · 1 comment
Open

Examples in documentation #47

bdice opened this issue Sep 19, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@bdice
Copy link
Member

bdice commented Sep 19, 2019

The documentation would be vastly more useful with some example code snippets. @klarh I'd appreciate your thoughts on this:

  • Do you want to include examples as a git submodule, as we've done for freud and fresnel (to keep the repo size reasonable)?
  • Should examples be based on https://github.com/glotzerlab/plato-gallery (should that repo be expanded to include more simple figures)?
  • What backends should we showcase for examples? Interactive vs. ray-traced?
  • Should the notebooks be pre-rendered (requires a dev machine or Docker image that works with all/most backends) or rendered on ReadTheDocs (potentially time-intensive, hard to configure dependencies)?

Related: I was able to embed pythreejs widgets into freud's documentation: https://freud.readthedocs.io/en/stable/examples/examples/Visualization%20with%20plato.html

@bdice bdice added the enhancement New feature or request label Sep 19, 2019
@klarh
Copy link
Collaborator

klarh commented Sep 19, 2019

I think linking in plato-gallery would be great! I had some configuration for nbsphinx integration in the nbsphinx branch, but I ran into a problem with one of the backends and left it to solve later. Currently that branch just includes the test scenes and displays which primitives were used in each test scene, but having more intelligent/meaningful scenes in plato-gallery (perhaps expanding on the tutorial notebooks) would be useful.

I think showcasing all the backends (to the extent that we can) would be useful; obviously some things lend themselves to looking nicer when raytraced than others, so keeping that in mind when choosing would be great.

If they are in plato-gallery already, I think it's fine to have the notebooks be pre-rendered (especially since readthedocs times out builds pretty quickly, if I recall correctly). If you want a docker image, I think you should be able to use the plato-tests image or generate one with repo2docker on either the plato or plato-gallery repositories, since binder integration with both has been working for a while now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants