Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when check if ntpServerIPAddress is unset #43

Open
JyunWei-Su opened this issue Jul 28, 2022 · 0 comments
Open

Bug when check if ntpServerIPAddress is unset #43

JyunWei-Su opened this issue Jul 28, 2022 · 0 comments

Comments

@JyunWei-Su
Copy link

JyunWei-Su commented Jul 28, 2022 •
edited
Loading

In function NTPClient::getTime () (file: ESPNtpClient.cpp), the statement if (ntpServerIPAddress == IPAddress (INADDR_NONE)) only work with ESP32.
I think this due to the IPAddress (INADDR_NONE)) is (IP unset) for esp8266, 0.0.0.0 for esp32.
Maybe it should be if(ntpServerIPAddress.toString() == IPAddress(INADDR_NONE).toString())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JyunWei-Su