Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor integration test test cases #291

Open
klieret opened this issue Apr 6, 2023 · 0 comments
Open

Refactor integration test test cases #291

klieret opened this issue Apr 6, 2023 · 0 comments

Comments

@klieret
Copy link
Member

klieret commented Apr 6, 2023

Waiting for #290 to be merged.

Currently, test cases are specified as

class TestTrainCase:
    model: str = "graphtcn"
    loss_weights: str = "default"
    ec_params: dict[str, Any] | None = None

and then later there's a long if, elif change turning these strings into the actual classes.

Better would be to directly do

test_case = TestTrainCase(
	model=GraphTCN(
          node_indim,
          edge_indim,
          h_dim=2,
          hidden_dim=2,
          L_ec=2,
          L_hc=2,
      )
)

etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant