Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine context reset breaks tests #3180

Open
Kouteki opened this issue Nov 22, 2024 · 0 comments
Open

Machine context reset breaks tests #3180

Kouteki opened this issue Nov 22, 2024 · 0 comments
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related

Comments

@Kouteki
Copy link
Contributor

Kouteki commented Nov 22, 2024

Description

We introduced #2975 to wipe the machine context before each test. The problem is that Onbloc has 90+ tests that now have to be run sequentially, and roughly half of the tests require context to be retained (e.g. block height):

  1. TestFunc2 gets affected by behavior in TestFunc1
  2. if TestFunc1 changes, we need to change every test code (because for gnoswap we need to check every number(token amount)

Example:

gnoswap staker tc

We should consider introducing an override for machine context.

Related #1982

@Kouteki Kouteki added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Nov 22, 2024
@Kouteki Kouteki moved this from Triage to Todo in 🧙‍♂️gno.land core team Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

No branches or pull requests

1 participant