Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move performance counter storage for global variable to virtual machine(s) #3187

Open
Kouteki opened this issue Nov 24, 2024 · 0 comments
Open
Labels
📦 🤖 gnovm Issues or PRs gnovm related

Comments

@Kouteki
Copy link
Contributor

Kouteki commented Nov 24, 2024

Regarding the storage of performance counters, they should be stored per virtual machine, instead of a global variable measure, which is generally a bad practice, bringing a lot of unstated constraints and risks. I understand that it is already the case for other parts of the VM, and that it facilitates the coding, but this is something that we should eventually fix. It can be done later, I don't want to block the PR for that.

Originally posted by @mvertes in #2241 (review)

Proposed upgrade of #2241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Backlog
Development

No branches or pull requests

1 participant