feat(gnovm): categorize imports #3323
Open
+198
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the imports utils split imports by file kinds, allowing to make explicit decisions about what imports to use at the various callsites
FileKind
enum to categorize gno files, with variantsCompiled
,Test
,Xtest
andFiletest
GetFileKind
util to derive theFileKind
from a file name and bodyImportsMap
type that mapsFileKind
s to lists of imports. It has a single methodMerge
to select and merge various imports from multipleFileKind
spackages.Imports
helper to return anImportsMap
instead of a[]string
and adapt callsites by usingImportMap.Merge
to preserve existing behaviorThis is something I need for #3304 and #2932 but to help reviews I made an atomic PR here instead