Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSW-1838 feat: grc20reg #412

Merged
merged 6 commits into from
Dec 10, 2024
Merged

GSW-1838 feat: grc20reg #412

merged 6 commits into from
Dec 10, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Dec 2, 2024

feat

  1. feat grc20reg from (feat: add grc20reg that works... today gnolang/gno#3135)
  • replace previous token_register to latest grc20reg

- replace previous token_register to latest grc20reg
@r3v4s r3v4s self-assigned this Dec 2, 2024
@r3v4s r3v4s added token align with grc20 or token related tasks refactoring labels Dec 2, 2024
@r3v4s r3v4s marked this pull request as ready for review December 2, 2024 08:18
notJoon
notJoon previously approved these changes Dec 2, 2024
@onlyhyde onlyhyde added the grc20-reg grc20 register related label Dec 4, 2024
@onlyhyde
Copy link
Member

onlyhyde commented Dec 4, 2024

Need to support deploy grc20reg where package is deployed
I did deploy it into r/demo/
But txtar test are failed with panic error

the below logs are error message

--- FAIL: TestTestdata (0.27s)
--- FAIL: TestTestdata/approve_and_transferfrom (0.26s)
panic: open /private/var/folders/yr/smh6x7ls0rbcg6zf8cwm4lgh0000gn/T/go-test-script3072483097/script-approve_and_transferfrom/echo: no such file or directory [recovered]
panic: open /private/var/folders/yr/smh6x7ls0rbcg6zf8cwm4lgh0000gn/T/go-test-script3072483097/script-approve_and_transferfrom/echo: no such file or directory [recovered]
panic: open /private/var/folders/yr/smh6x7ls0rbcg6zf8cwm4lgh0000gn/T/go-test-script3072483097/script-approve_and_transferfrom/echo: no such file or directory [recovered]
panic: open /private/var/folders/yr/smh6x7ls0rbcg6zf8cwm4lgh0000gn/T/go-test-script3072483097/script-approve_and_transferfrom/echo: no such file or directory

@r3v4s
Copy link
Member Author

r3v4s commented Dec 5, 2024

Need to support deploy grc20reg where package is deployed I did deploy it into r/demo/ But txtar test are failed with panic error

the below logs are error message

--- FAIL: TestTestdata (0.27s) --- FAIL: TestTestdata/approve_and_transferfrom (0.26s) panic: open /private/var/folders/yr/smh6x7ls0rbcg6zf8cwm4lgh0000gn/T/go-test-script3072483097/script-approve_and_transferfrom/echo: no such file or directory [recovered] panic: open /private/var/folders/yr/smh6x7ls0rbcg6zf8cwm4lgh0000gn/T/go-test-script3072483097/script-approve_and_transferfrom/echo: no such file or directory [recovered] panic: open /private/var/folders/yr/smh6x7ls0rbcg6zf8cwm4lgh0000gn/T/go-test-script3072483097/script-approve_and_transferfrom/echo: no such file or directory [recovered] panic: open /private/var/folders/yr/smh6x7ls0rbcg6zf8cwm4lgh0000gn/T/go-test-script3072483097/script-approve_and_transferfrom/echo: no such file or directory

@onlyhyde
typo fixed
7a215a8

- it's been merged into master of gnolang/gno
@r3v4s r3v4s requested a review from notJoon December 6, 2024 02:20
Copy link

sonarcloud bot commented Dec 9, 2024

@onlyhyde onlyhyde merged commit 5965d6d into main Dec 10, 2024
2 checks passed
@onlyhyde onlyhyde deleted the feat/grc20-reg branch December 10, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grc20-reg grc20 register related refactoring token align with grc20 or token related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants