Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1838 fix: test errors are fixed #422

Merged
merged 4 commits into from
Dec 9, 2024
Merged

GSW-1838 fix: test errors are fixed #422

merged 4 commits into from
Dec 9, 2024

Conversation

onlyhyde
Copy link
Member

@onlyhyde onlyhyde commented Dec 6, 2024

  • Integrate helper functions for tests
  • Change file extensions to prevent test code in the test folder from being executed
  • Fixing failure errors due to code integration
  • Known issue : Fixed additional test failure case related to getter

@onlyhyde
GSW-1838 fix: test errors are fixed
d9346ff 
- Integrate helper functions for tests
- Change file extensions to prevent test code in the test folder from being executed
- Fixing failure errors due to code integration
- Known issue : Fixed additional test failure case related to getter
@onlyhyde onlyhyde requested review from notJoon and r3v4s December 6, 2024 06:50
@onlyhyde onlyhyde self-assigned this Dec 6, 2024
@onlyhyde
Copy link
Member Author

onlyhyde commented Dec 6, 2024

@r3v4s
There are still test failures related to the getter. There are a lot of functions that need to be fixed, so I'll ask the existing person in charge. Also, the pool_manager related test code is all outdated. Please fix it according to our rule.

@onlyhyde
Copy link
Member Author

onlyhyde commented Dec 6, 2024

With the additional commit from @r3v4s , all test code will pass when the current PR is applied.

@onlyhyde onlyhyde mentioned this pull request Dec 6, 2024
Merged
r3v4s
r3v4s approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just simple question,
Can we make users.Resolve(admin) it as var or const ??
I really don't see pros for keep resolving AddressOrName type to address.

@r3v4s
Copy link
Member

r3v4s commented Dec 8, 2024

FYI, @onlyhyde @notJoon

to finish #414 (which also includes work from #412 #413) this pr needs to be merge first, so I can update some test cases without many conflicts.

@onlyhyde onlyhyde merged commit 0b2f4ae into main Dec 9, 2024
@onlyhyde onlyhyde deleted the refactor/pool-contract branch December 9, 2024 03:32
r3v4s added a commit that referenced this pull request Dec 10, 2024
@onlyhyde @r3v4s
GSW-1838 fix: test errors are fixed (#422)
23a3bed 
* GSW-1838 fix: test errors are fixed

- Integrate helper functions for tests
- Change file extensions to prevent test code in the test folder from being executed
- Fixing failure errors due to code integration
- Known issue : Fixed additional test failure case related to getter

* fix: remove time compare in unit test

* fix: do not setup data in init

* test: pool manger testcase

---------

Co-authored-by: n3wbie <[email protected]>
r3v4s added a commit that referenced this pull request Dec 10, 2024
@onlyhyde @r3v4s
GSW-1838 fix: test errors are fixed (#422)
f2a3127 
* GSW-1838 fix: test errors are fixed

- Integrate helper functions for tests
- Change file extensions to prevent test code in the test folder from being executed
- Fixing failure errors due to code integration
- Known issue : Fixed additional test failure case related to getter

* fix: remove time compare in unit test

* fix: do not setup data in init

* test: pool manger testcase

---------

Co-authored-by: n3wbie <[email protected]>
r3v4s added a commit that referenced this pull request Dec 10, 2024
@onlyhyde @r3v4s
GSW-1838 fix: test errors are fixed (#422)
16dfe8e 
* GSW-1838 fix: test errors are fixed

- Integrate helper functions for tests
- Change file extensions to prevent test code in the test folder from being executed
- Fixing failure errors due to code integration
- Known issue : Fixed additional test failure case related to getter

* fix: remove time compare in unit test

* fix: do not setup data in init

* test: pool manger testcase

---------

Co-authored-by: n3wbie <[email protected]>
notJoon added a commit that referenced this pull request Dec 11, 2024
@notJoon @onlyhyde
Merge pull request #414 from gnoswap-labs/refactor/pool_grc20reg
78dfa75 
* GSW-1838 refactor: use grc20reg
- use gno's grc20reg realm to support dynamic token transfer in pool

* GSW-1838 feat: grc20reg
- replace previous token_register to latest grc20reg

* feat: update grc20 spec for grc20reg

* hotfix: update bar token spec

* feat: get token object from `grc20-reg` in `common`

* fix: typo

* chore: remove grc20reg
- it's been merged into master of gnolang/gno

* feat: get `token` and `teller` object from grc20reg

* test: txtar for approve & transferfrom using grc20reg

* feat: use teller to transfer token

* feat: IsRegistered() to check if token is registered or not

* refactor: remove old token_register

* chore: rename teller

* feat: guard logic to see if token is registered

* feat: MustRegistered in common
- if token is not registered, it will panic.

* chore: rename

* GSW-1838 fix: test errors are fixed (#422)

* GSW-1838 fix: test errors are fixed

- Integrate helper functions for tests
- Change file extensions to prevent test code in the test folder from being executed
- Fixing failure errors due to code integration
- Known issue : Fixed additional test failure case related to getter

* fix: remove time compare in unit test

* fix: do not setup data in init

* test: pool manger testcase

---------

Co-authored-by: n3wbie <[email protected]>

* GSW-1838 refactor: use grc20reg
- use gno's grc20reg realm to support dynamic token transfer in pool

* fix: gno.mod tidy

* fix: missing guard logic for HandleWithdrawalFee

* fix: failing testcase

* fix: tc

* feat: use teller to transfer/transferfrom

* test: fix mocking old functions

* test: remove hardcoded value

* test: detail error message

* fix: typo

* remove: duplicate token register check

* fix: typo

* refactor: duplicate token register check

- GetPoolPath has check function

---------

Co-authored-by: 0xTopaz <[email protected]>
Co-authored-by: 0xTopaz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r3v4s r3v4s r3v4s approved these changes

@notJoon notJoon notJoon approved these changes

Assignees

@onlyhyde onlyhyde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onlyhyde @r3v4s @notJoon