Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomail library unmaintained #18664

Open
fnetX opened this issue Feb 7, 2022 · 9 comments · May be fixed by #32682
Open

gomail library unmaintained #18664

fnetX opened this issue Feb 7, 2022 · 9 comments · May be fixed by #32682
Labels
type/upstream This is an issue in one of Gitea's dependencies and should be reported there

Comments

@fnetX
Copy link
Contributor

fnetX commented Feb 7, 2022

The gomail library used by Gitea is out of date. Transfer from me from the channel (Matrix)

Gitea seems to use https://github.com/go-gomail/gomail which is unmaintained since 2016, and the "actively maintained" fork appears unmaintained, too: https://github.com/go-mail/mail/
Do you consider this an issue for you? I looked at some Gitea issues, and some cases like different timeouts / retries is also a feature request to both frameworks, but apparently never implemented. Does a switch make sense, or is the current state perfectly fine?

Discussion already started here:

FYI

Maybe we should maintain gomail by ourselves, or switch to another one. Then we may not need hacky code.

Some active forks:

Originally posted by @wxiaoguang in #18075 (comment)
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 8, 2022 •
edited
Loading

FYI, there were more comments.

  1. These active forks seem not ideal. Add option to convert CRLF to LF line endings for sendmail #18075 (comment)
  2. IIRC many contributors accepted to maintain the gomail by ourselves since it's not complex.

@lunny
Copy link
Member

lunny commented Feb 8, 2022

How about convert to https://github.com/xhit/go-simple-mail .

@noerw noerw added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label Mar 12, 2022
@wxiaoguang wxiaoguang mentioned this issue Feb 8, 2023
Open
@fredmenez
Copy link

FYI the maintainer of go-gomail/gomail has left this world, details in go-gomail/gomail#182.

@techknowlogick
Copy link
Member

@fredmenez thank you for sharing this news with us ❤️ 🕯️

@Neustradamus
Copy link

Dear all, it is possible to change your code?
Change from here:

It has been unmaintained and maybe one or more vulnerabilities :/

There are:

Linked to:

@lunny
Copy link
Member

lunny commented Nov 23, 2024

Maybe https://github.com/wneessen/go-mail is a better choice.

@Neustradamus
Copy link

@lunny: Thanks for your reactivity!
Yes totally! :)

@lunny
Copy link
Member

lunny commented Nov 23, 2024

First step #32618 to move to the new package.

@Neustradamus
Copy link

@lunny: Thanks for your quick PR!

@lunny lunny mentioned this issue Nov 25, 2024
Merged
lafriks pushed a commit that referenced this issue Nov 30, 2024
@lunny
Split mail sender sub package from mailer service package (#32618)
79d593a 
Move all mail sender related codes into a sub package of
services/mailer. Just move, no code change.
Then we just have dependencies on go-mail package in the new sub
package. We can use other package to replace it because it's
unmaintainable. ref #18664
@lunny lunny linked a pull request Nov 30, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new mail package instead of an unmintained one lunny/gitea
7 participants
@lunny @Neustradamus @techknowlogick @wxiaoguang @fredmenez @noerw @fnetX