Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: phase 1 changes: add comments feat to unchanged lines in the pullrequest #32471

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

feat: phase 1 changes: add comments feat to unchanged lines in the pullrequest #32471

wants to merge 29 commits into from
+303 −102

Conversation

rajesh-jonnalagadda
Copy link

@rajesh-jonnalagadda rajesh-jonnalagadda commented Nov 11, 2024 •
edited
Loading

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 11, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 11, 2024
@algora-pbc algora-pbc bot mentioned this pull request Nov 11, 2024
Open
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Nov 11, 2024
@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-32257-add-comments-unchanged-lines-and-show branch 2 times, most recently from e59800b to ed80303 Compare November 11, 2024 02:46
@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-32257-add-comments-unchanged-lines-and-show branch from ed80303 to abd1d2f Compare November 11, 2024 03:34
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as draft November 11, 2024 16:59
@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-32257-add-comments-unchanged-lines-and-show branch from 8c34f45 to 7c39ad2 Compare November 11, 2024 17:27
@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-32257-add-comments-unchanged-lines-and-show branch from 3fbf96f to ccd797a Compare November 11, 2024 17:50
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as ready for review November 11, 2024 18:29
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as draft November 11, 2024 19:19
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as ready for review November 11, 2024 23:56
@rajesh-jonnalagadda
Copy link
Author

@lunny Can you please review

@rajesh-jonnalagadda
Copy link
Author

@lunny Could you please review my changes? If the PR isn't relevant, feel free to close it.

@lunny
Copy link
Member

lunny commented Nov 13, 2024

@lunny Could you please review my changes? If the PR isn't relevant, feel free to close it.

I will review it in the following week.

@rajesh-jonnalagadda
Copy link
Author

@lunny Could you please review my changes? If the PR isn't relevant, feel free to close it.

I will review it in the following week.

May I know the status of the review?

@lunny
Copy link
Member

lunny commented Nov 27, 2024

Some problems when I test it.
1 I have only one comment on the line 1, but there are two comments icon in the first line and last line.
image

2 The comment icon is clickable but no response when clicking.
image

3 The menu in the top right corner of the comment cannot be popped up.
image

@rajesh-jonnalagadda
Copy link
Author

rajesh-jonnalagadda commented Nov 27, 2024 •
edited
Loading

Some problems when I test it. 1 I have only one comment on the line 1, but there are two comments icon in the first line and last line. image

2 The comment icon is clickable but no response when clicking. image

3 The menu in the top right corner of the comment cannot be popped up. image

Point 1: would greatly help if I have exact replication steps. I will try to replicate it.
point 2: should I make it non-clickable? ideally, I want to show only icon
point 3: need to debug it.

@rajesh-jonnalagadda
Copy link
Author

point 1 I am able to replicate. need conformation on point2

@rajesh-jonnalagadda
Copy link
Author

@lunny fixed the issues. can you please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🙋 Bounty claim lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajesh-jonnalagadda @lunny @GiteaBot