tests(coordinator): Improve unit test coverage (#98)

* tests(coordinator): Improve unit test coverage Signed-off-by: Flc゛ <[email protected]> * tests(coordinator): Improve unit test coverage Signed-off-by: Flc゛ <[email protected]> --------- Signed-off-by: Flc゛ <[email protected]>
go-fries · Feb 15, 2024 · c57bd61 · c57bd61
1 parent 26a6f6b
commit c57bd61
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/coordinator/manager.go b/coordinator/manager.go
@@ -4,7 +4,7 @@ import "sync"
 
 type Manager struct {
 	coordinators map[string]*Coordinator
-	mu           sync.RWMutex
+	mu           sync.Mutex
 }
 
 func NewManager() *Manager {

diff --git a/coordinator/manager_test.go b/coordinator/manager_test.go
@@ -9,7 +9,7 @@ import (
 
 func TestManager(t *testing.T) {
 	wg := sync.WaitGroup{}
-	ch := make(chan struct{}, 2)
+	ch := make(chan struct{}, 10)
 
 	c1 := Until("foo")
 	c2 := Until("foo")
@@ -39,4 +39,30 @@ func TestManager(t *testing.T) {
 
 	wg.Wait()
 	assert.Equal(t, 2, len(ch))
+
+	// Clear all coordinators
+	Clear()
+
+	c3 := Until("foo")
+	assert.NotSame(t, c1, c3)
+
+	// Close foo coordinators
+	wg.Add(1)
+	go func() {
+		defer wg.Done()
+
+		if <-c3.Done(); true {
+			ch <- struct{}{}
+			return
+		}
+	}()
+	assert.Equal(t, 2, len(ch))
+	Close("foo")
+	wg.Wait()
+	assert.Equal(t, 3, len(ch))
+
+	// Close non-exist coordinator
+	assert.NotPanics(t, func() {
+		Close("bar")
+	})
 }