Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encode []*time.Time - check nil #524

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix encode []*time.Time - check nil #524

merged 1 commit into from
Nov 11, 2024

Conversation

mirecl
Copy link
Contributor

@mirecl mirecl commented Oct 3, 2024

@goccy, thank you very much for the library, it really improves performance a lot - blazing fast!!!
But I found incompatibility with the standard library (encoding/json) for Marshal []*time.Time (issue #523)
I have prepared a fix, I really hope for a prompt review my PR.

@mirecl
Copy link
Contributor Author

mirecl commented Oct 4, 2024

@goccy, tell me what you think about this fix?

@mirecl
Copy link
Contributor Author

mirecl commented Oct 14, 2024

@goccy, up

@mirecl
Copy link
Contributor Author

mirecl commented Oct 23, 2024

@shamaton, what you think about this fix?

@shamaton
Copy link
Contributor

I’m sorry but I’m not a maintainer this repository. I have no idea about this fix.

@mirecl
Copy link
Contributor Author

mirecl commented Nov 10, 2024

@goccy , up

Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goccy goccy merged commit 65c8b28 into goccy:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants