Add popup_create_dialog() for EditorInterface to create custom create dialog

[Lazy-Rabbit-2001]

Supersedes #99926

Adds a new method pop_create_dialog() for EditorInterface, which allows users to pop a custom create dialog.

Parameters

Callable callback: This callback requires only one argument which is of StringName type, where a user can define instantiating an object by calling ClassDB.instantiate(...) or Script.new(...).
StringName base_type: This defines the root type of the create dialog. By default it is Object. For example, if one defines this as Node2D, only a Node2D and all of its derived class can be displayed.
String dialog_title: This allows you tp customize the title of the create dialog. An empty string for this will make the title fall back to "Create New ".
Array[StringName] type_blocklist: This will customize which types should be hidden from the custom create dialog. A hidden type is unable to be selected or interacted.
Dictionary type_suffixes: This will customize the suffixes of types shown in the custom create dialog. Suffixes, for global script classes, are by default the file names of the scripts. If a suffix is an empty string, there will be no suffix following the type name.

[KoBeWi]

• Type blacklist doesn't take effect immediately:

i1f6SKNmzW.mp4

You need to close the dialog and open it again.

• Canceling the dialog does not call the callback. It should be called with empty String, for consistency with other popup methods.
• Type suffixes have the same problem as blacklist.
• Also there is no way to remove a suffix. If you use empty String, the previous valid suffix will be repeated.
  Looking at the proposal, empty String is supposed to remove the suffix altogether. I'd suggest the following:
• If you pass an empty string as suffix, remove the suffix.
• If a class is no longer in suffix Dictionary (in subsequent call), restore default suffix.

---

I think exposing the dialog this way makes sense, but the additional functionality (blacklist, suffixes) is questionable. The proposal doesn't seem to have gained support. Can't say how much useful it is.

[AThousandShips]

Should preferably be called "blocklist" instead, as per the general pattern and preferred terminology

[Lazy-Rabbit-2001]

• Type blacklist doesn't take effect immediately:
• Canceling the dialog does not call the callback. It should be called with empty String, for consistency with other popup methods.
• Type suffixes have the same problem as blacklist.
• Also there is no way to remove a suffix. If you use empty String, the previous valid suffix will be repeated.
  Looking at the proposal, empty String is supposed to remove the suffix altogether.

All of these bugs are fixed

[KoBeWi]

The Dictionary could be typed.
(AFAIK you ran into some problems with it; it would still be nice to resolve it though)

[Lazy-Rabbit-2001]

The Dictionary could be typed. (AFAIK you ran into some problems with it; it would still be nice to resolve it though)

Yeah, but I'd wait for others who maintains the typed dictionary to solve the problem and then I'll make a new pr to transform all dictionaries into typed dictionaries (as long as their keys or values should be typed)

[KoBeWi]

Well the problem is that adding type technically breaks compatibility, so we should do it swiftly.

[Lazy-Rabbit-2001]

Nvm, wait for someone to fix #100137 ...

[KoBeWi]

The replace mode that you newly exposed sounds like niche feature 🤔 It could default to false and the argument could be moved before replace_type_name. Though not sure if it's even useful.

[Lazy-Rabbit-2001]

The replace mode that you newly exposed sounds like niche feature 🤔 It could default to false and the argument could be moved before replace_type_name. Though not sure if it's even useful.

I prefer to make it exposed, as some users will pop the dialog for literally replacing the type.
Or add a method to override the title, which is also ok.

[KoBeWi]

The crash is still not fixed #100135 (comment)

[Lazy-Rabbit-2001]

The crash is still not fixed #100135 (comment)

Fixed in the latest pr that will be pushed soon

...
create_dialog->set_type_suffixes(suffix_map);

const bool is_type_valid = ClassDB::class_exists(p_base_type) || ScriptServer::is_global_class(p_base_type);
if (!is_type_valid) {
	ERR_PRINT(vformat("Invalid base type '%s'. The base type has fallen back to 'Object'.", p_base_type));
}
const String safe_base_type = !p_base_type.is_empty() && is_type_valid ? p_base_type : "Object";

create_dialog->set_base_type(safe_base_type);
...

[KoBeWi]

Functionality-wise it's fine now.
Apparently type blocklist already existed, it was just hard-coded before.
The suffixes and dialog title are questionable, but eh.

[akien-mga]

Thanks!