[3.3] Misc. build and warning fixes to pass CI and compile with recent SCons and GCC/Clang #98867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
3.3-ci-build-warning-fixes
branch
from
57c38a3 to
77b677e
Compare
(cherry picked from commit 55845ba)
(cherry picked from commit 6f02183)
Co-authored-by: bruvzg <[email protected]> (cherry picked from commit a297a69)
Fix `-Wunused-but-set-variable`, `-Wunqualified-std-cast-call`, and `-Wliteral-range` warnings. (cherry picked from commit d8935b2)
akien-mga
force-pushed
the
3.3-ci-build-warning-fixes
branch
from
77b677e to
f52fd8d
Compare
(cherry picked from commit e771804)
Fixes the following error:
thirdparty/vhacd/inc/vhacdICHull.h:46:31: error: 'uint32_t' does not name a type
46 | ICHullError Process(const uint32_t nPointsCH, const double minVolume = 0.0);
| ^~~~~~~~
Note the upstream version of the third party library is not affected.
(cherry picked from commit a648d83)
Fixes godotengine#77927. (cherry picked from commit 10676e7)
Fixes godotengine#91206. (cherry picked from commit a8ff47b)
akien-mga
force-pushed
the
3.3-ci-build-warning-fixes
branch
from
f52fd8d to
a53860d
Compare
akien-mga
force-pushed
the
3.3-ci-build-warning-fixes
branch
5 times, most recently
from
e4ef29c to
435246b
Compare
bagder/ca-bundle@4d3fe66 Document matching mozilla-release changeset. (cherry picked from commit eb41ff0)
akien-mga
force-pushed
the
3.3-ci-build-warning-fixes
branch
from
435246b to
3772a5f
Compare
|
Finally passing checks. This was a bit harder than |
akien-mga
changed the title
akien-mga
commented
Nov 6, 2024
Comment on lines
+21
to
+25
| <<<<<<< HEAD | ||
| - uses: actions/checkout@v4 | ||
| ======= | ||
| - uses: actions/checkout@v4 | ||
| >>>>>>> 6b202812ff (CI: Update all GitHub actions to their latest version) |
There was a problem hiding this comment.
Oof, how did this pass CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.3equivalent to [3.4] Misc. build and warning fixes to pass CI and compile with recent SCons and GCC/Clang #98864.Likewise, this doesn't mean restarting active support for the
3.3branch, this is just a code/history preservation improvement.