-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test for jsonpb support for Any and Struct #197
Labels
Comments
This was referenced Sep 10, 2016
The blocking issues in golang/protobuf have been resolved as of golang/protobuf@18c9bb3. |
I am on holiday. I'll merge this when I get back after 16 May.
…On Fri, 28 Apr 2017, 20:57 Zack, ***@***.***> wrote:
The blocking issues in golang/protobuf
<https://github.com/golang/protobuf/> have been resolved as of
***@***.***
<golang/protobuf@18c9bb3>
.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#197 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvsLUt0WcaZBFSqK32ZsPDFpGi4_OqIks5r0jaUgaJpZM4J5qts>
.
|
Excellent, thank you! |
Merged golang/protobuf@18c9bb3 |
Probably some tests should be reenable for gogo/protobuf: https://github.com/gogo/protobuf/blob/master/test/types/types.proto#L66-L68 |
Oooo good catch. How do you feel about making a pull request? |
See PR #406, still it seems to fail on my machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is blocked on
golang/protobuf#208
golang/protobuf#216
The text was updated successfully, but these errors were encountered: