Add option to not expose Harbor.

[Vad1mo]

This contribution allows users to not expose Harbor so that they use their preferred way of exposing Harbor, that should be outside the scope of this Helm Chart.

The main reasons someone would not expose Harbor is because they are planning to expose Harbor in a way not supported by this Helm Chart:

Examples:

• Istio Gateway
• AWS ALB

Those two examples that have been requested frequently by the community.
This contribution would allow users to define whatever way they want to expose Harbor.

Closes #1132, #1006, #914, #295, #1672

[reasonerjt]

Hi @Vad1mo

Thanks for the PR but seems you can just set the .Values.expose.type to something like none to achieve the same goal?
Have you tried that?

[Vad1mo]

@reasonerjt I tried to set ingress to none but it didn't work.

helm template --set "expose.type=none" . > test-none.yaml
Error: execution error at (harbor/templates/nginx/secret.yaml:3:12): The "expose.tls.auto.commonName" is required!

After looking into the templates, it would have meant to do some more rewriting to make it work with none I decided not to do this because of Consistency over verbosity: enable=true is a common and known practice when working with Helm.

[ninjadq]

hi @Vad1mo , because the error is caused by commonName, how about just assign an arbitrary name for expose.tls.auto.commonName as a workaround? so we can avoid changes a lots of code here

[Vad1mo]

Having this switch explicitly in the Harbor Helm Chart has a few advantages over implicit workarounds:

1. Implicit workarounds can stop working and there is no clear documentation or lookup possibility in the code.
2. Explicit documentation and workflow allow users to find exactly the solution to their problem.

Apart from implicit vs. explicit, this feature has a few advantages:
This functionality allows using Harbor with every ingress controller, and the Harbor Helm Chart doesn't have to support every use case.

[Vad1mo]

Can I get your attention @reasonerjt @ninjadq on this PR? especially after my comment explaining the reason for the explicitly? ☝️

[CloudlightCoUk]

I share the use case above. For my project I don't want to use nginx as a proxy. The chart as it is either creates a nginx object, or trys to deploy nginx. I am using Contour with a HTTPProxy object for my front end proxy. The Harbor application architecture defines a proxy layer, so we should have the option to disable this in the chart to 'bring your own proxy'

[Vad1mo]

closed in favor #1687