Implement the "rewrite" middleware from distribution

[adam-lebon]

Is your feature request related to a problem? Please describe.
I use GoHarbor with MinIO as storage.

GoHarbor accesses MinIO using an internal network that is not accessible from the outside On the other hand, MinIO is publicly accessible using a load balancer, but this load balancer cannot be reached by Harbor.

Redirection has therefore been disabled in Harbor.

Describe the solution you'd like.
Last year, the “distribution” project implemented a new middleware called “rewrite”. It replaces the scheme and hostname returned to the client during a docker pull.

This seems to be the ideal solution to our problem since it should allow harbor to reach minio using the internal address while returning a public address to clients.

Describe the main design/architecture of your solution
The solution would be to implement this “rewrite” middleware like the cloudfront middleware.

distribution/distribution#4146

[wy65701436]

since the above pull request wasn't in the distribution v2.8.3, so currently Harbor cannot support it.

cc @Vad1mo did some testing on distribution v3, maybe he can share more infor.

[stonezdj]

You can disable registry redirect when the client can not access the minio.

see https://github.com/goharbor/harbor/blob/main/make/harbor.yml.tmpl#L82

[adam-lebon]

Hello,
As stated in first message, it works if I disable redirects as you pointed out.

However, I'll be serving docker images to hundreds of client simultaneously, this is why I'm looking for lowering the stress applied to Harbor.

If I achieve to enable this rewrite middleware, the stress should be applied to minio instead of harbor+minio.

If I get some time during the next week I'll try to implement this middleware to harbor

[Vad1mo]

You can use the v3 distribution rewrite middleware. according to

• https://distribution.github.io/distribution/storage-drivers/middleware/rewrite/

just replace the image from to upstream

[adam-lebon]

I'm currently deploying harbor using the bitnami helm chart.
If I've understood correctly, I need to disable the harbor registry deployment, then replace it with the upstream distribution project ? @Vad1mo