Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Lint Check for Invalid JSON Files in i18n #21685

Open
bupd opened this issue Mar 3, 2025 · 5 comments · May be fixed by #21687
Open

Missing Lint Check for Invalid JSON Files in i18n #21685

bupd opened this issue Mar 3, 2025 · 5 comments · May be fixed by #21687
Labels
good first issue good first issue

Comments

@bupd
Copy link
Contributor

bupd commented Mar 3, 2025

Overview

The tests currently does not cover checking of invalid json files.
for example JSON files residing inside src/portal/src/i18n/**-lang.json these files need to be lint checked.

Steps to reproduce the problem

  1. Create a PR with invalid json in the i18n folder.
  2. The PR will pass all the checks. eventhough JSON file in malformed.

Steps on Fixing this issue

  • Implement a lint check (e.g., using a tool like jsonlint or a custom script) to validate all JSON files inside src/portal/src/i18n/.
  • Ensure that invalid JSON files cause the PR to fail.
  • Ensure the JSON lint check runs automatically as part of the CI/CD pipeline.

Thanks

@bupd
Copy link
Contributor Author

bupd commented Mar 3, 2025

/label good first issue

@davutkilic
Copy link

can you assign this to me

@bupd
Copy link
Contributor Author

bupd commented Mar 3, 2025

@davutkilic feel free to open a PR once you have a fix.

@davutkilic davutkilic linked a pull request Mar 3, 2025 that will close this issue
@Vad1mo Vad1mo added the good first issue good first issue label Mar 3, 2025
@davutkilic
Copy link

opened a PR

@bupd
Copy link
Contributor Author

bupd commented Mar 11, 2025

I have left a review on PR. Please feel free to update the PR.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants