Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Copy Pull Button Overlap with Tag Immutable Label #21720

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Copy Pull Button Overlap with Tag Immutable Label #21720

wants to merge 2 commits into from

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Mar 11, 2025

Thank you for contributing to Harbor!

Comprehensive Summary of your change

  • updated CSS

Issue being fixed

Fixes #21712

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd
fix: copy button overlap with tag immutable
dc36781 
- fix copy button overlap with tag immutable label on artifact-tag
component
- update css to fix this issue

Signed-off-by: bupd <[email protected]>
@bupd bupd requested a review from a team as a code owner March 11, 2025 12:14
@bupd bupd mentioned this pull request Mar 11, 2025
Open
@bupd
Copy link
Contributor Author

bupd commented Mar 11, 2025

/label "release-note/update", "target/2.13.0"

@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.31%. Comparing base (c8c11b4) to head (2c2a95e).
Report is 404 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21720      +/-   ##
==========================================
+ Coverage   45.36%   46.31%   +0.94%     
==========================================
  Files         244      250       +6     
  Lines       13333    14133     +800     
  Branches     2719     2908     +189     
==========================================
+ Hits         6049     6545     +496     
- Misses       6983     7242     +259     
- Partials      301      346      +45
Flag Coverage Δ
unittests 46.31% <ø> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 494 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wy65701436 wy65701436 added target/2.13.0 issues that are targeting v2.13.0 release-note/update Update or Fix labels Mar 12, 2025
wy65701436
wy65701436 approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@OrlinVasilev OrlinVasilev

@chlins chlins

@MinerYang MinerYang

@xuelichao xuelichao

Labels
release-note/update Update or Fix target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The tag immutable icon overlaped with the command icon
6 participants
@bupd @wy65701436 @OrlinVasilev @chlins @MinerYang @xuelichao