Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuration of the LocalHTTPProxy #54

Open
shadeofblue opened this issue Oct 4, 2022 · 0 comments
Open

allow configuration of the LocalHTTPProxy #54

shadeofblue opened this issue Oct 4, 2022 · 0 comments

Comments

@shadeofblue
Copy link
Contributor

shadeofblue commented Oct 4, 2022

Allow configuration of the local address

currently, the local addresses from the LocalHTTPProxy are always reported as e.g.:

http://localhost:8081

add a configuration option (in the yaml config file (not the app descriptor)) to allow specification of the address

http_proxy:
    address: "https://my.address.com",

Add local port limits

allow the runner to limit the local ports available to be exposed by the run app:

http_proxy:
    ports:
        - "8080:9090"
        - "10000"

and allow only mappings within the specified ranges when choosing the port in _start_local_proxy

when an app specifies an explicit port outside this range, raise a RunnerError

(+ possibly also move get_free_port to runner.util and also raise a RunnerError when it finds out there are no more available ports)

@shadeofblue shadeofblue changed the title allow configuration of the local address of the LocalHTTPProxy allow configuration of the LocalHTTPProxy Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant