Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace logrus with log/slog #1890

Open
uhthomas opened this issue Sep 14, 2023 · 6 comments · May be fixed by #2010
Open

Replace logrus with log/slog #1890

uhthomas opened this issue Sep 14, 2023 · 6 comments · May be fixed by #2010
Labels
enhancement New feature or request good first issue Great issues for new Athenians to work on!
Milestone
0.15.0

Comments

@uhthomas
Copy link
Contributor

Given the release of log/slog, it would be nice to replace logrus with it. There isn't really a great standard for logging in this repository, so this could also be considered a feature request for better logging in general.

I found it hard to add new log lines when working on #1887.
@Ullaakut Ullaakut mentioned this issue Dec 21, 2023
Merged
@matt0x6F
Copy link
Contributor

I'm okay with this change, I think it would be a step in the right direction since Logrus is in maintenance mode. There's some specialized field renaming that happens with CloudRuntime that we'd need to accommodate but I think everything else is pretty straight forward.

@matt0x6F matt0x6F added enhancement New feature or request good first issue Great issues for new Athenians to work on! labels Mar 26, 2024
@matt0x6F matt0x6F added this to the 0.14.0 milestone Mar 28, 2024
@matt0x6F matt0x6F modified the milestones: 0.14.0, 0.15.0 Apr 20, 2024
@Vector-ops
Copy link

I want to work on this

@matt0x6F
Copy link
Contributor

matt0x6F commented Sep 9, 2024

@Vector-ops go for it

@leonhfr
Copy link

leonhfr commented Oct 3, 2024

Are you working on this @Vector-ops? Otherwise I'd like to give it a shot

@Vector-ops
Copy link

Are you working on this @Vector-ops? Otherwise I'd like to give it a shot

I was working on it but I have my hands full right now. You can have it

@JodhwaniMadhur JodhwaniMadhur linked a pull request Dec 2, 2024 that will close this issue
Draft
JodhwaniMadhur pushed a commit to JodhwaniMadhur/athens that referenced this issue Dec 4, 2024
gomods#1890 modifying logger pkg to use slog
647228e
@JodhwaniMadhur
Copy link

can you guys please invite me to your slack group? I am unable to join from the link in the readme. my email is [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Great issues for new Athenians to work on!
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

replacing logrus with slog v1 JodhwaniMadhur/athens
5 participants
@matt0x6F @uhthomas @leonhfr @JodhwaniMadhur @Vector-ops