proxy sumdb with first not-direct GOPROXY #1723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arschles
reviewed
Jan 31, 2022
There was a problem hiding this comment.
I haven't thought about this problem for a while and I know there are a lot of considerations to think about here. @marwan-at-work @manugupt1 do either of you have thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
athens is not working for people who can not access https://sum.golang.org. A go mod proxy should also proxy sumdb requests.
How is the fix applied?
redirect sum.golang.org sumdb to first not-direct proxy set in GOPROXY, like https://goproxy.cn
What GitHub issue(s) does this PR fix or close?
Fixes #1468