-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.2.0 is asking for activesupport < 6.0 with ruby 2.7+ #1723
Comments
Any chance this will get fixed? |
The issues is obsoleted. So could you please try again with latest gooddata gem ? |
The issue is obsoleted due to occurred for old version of gooddata gem. So I will close the issue. |
@hung-nguyen-hoang 2.2.0 has the same problem. |
Hi @andrehjr, |
@hung-nguyen-hoang Create a file like this: gooddata_test.rb # frozen_string_literal: true
require "bundler/inline"
gemfile(true) do
source "https://rubygems.org"
ruby '3.2.0' # or some other version you have locally
gem "rails", "~> 6.0"
gem "gooddata", "~> 2.2"
end Execute:
I don't think the RUBY_VERSION >= '2.5' on the gemspec works for published gems, because when you push the gem. That's what gets sent to Rubygems.org. If you look there. You can the runtime dependencies are fixed. Full log output: https://gist.github.com/andrehjr/a1eab22abb02ea656cc1856f0f809257 |
@hung-nguyen-hoang gemspec is executed on your computer, not the user's computer. It is executed to build the gem, not install it. |
I raised ticket for our team to investigate and support the case ticket We will message to you, when we have a plan to fix it. |
Hi,
There's a conditional on the gemspec to specify the requirements for activesupport which does not seem to be working.
https://github.com/gooddata/gooddata-ruby/blob/master/gooddata.gemspec#L57-L61
I think that will only work when you build gem locally and
gem push
?Will result in:
The requirements for each version on rubygems changed over time.
The text was updated successfully, but these errors were encountered: