Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create better default values for threshold/history #116

Open
fnoop opened this issue Dec 17, 2019 · 1 comment
Open

Create better default values for threshold/history #116

fnoop opened this issue Dec 17, 2019 · 1 comment

Comments

@fnoop
Copy link
Member

fnoop commented Dec 17, 2019

No description provided.

@kripper
Copy link

kripper commented Mar 20, 2023

I guess the threshold and history was needed in order to avoid bouncing between markers.
In https://github.com/kripper/vision-landing-2/ we don't land on a marker center, but on a landing point that is defined relatively to all markers.
So there is no bouncing and any marker can be used.
Actually we prefer to use the biggest detected marker because "more pixels" => "better estimation".

In case the marker detection wouldn't be robust enough, appriltags also provides a confidence value that could be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants