[Question] AICS - Gain Setting values/format

[wpiet]

Hi,

I noticed that in bumble/profiles/aics.py the specified range for Gain Setting Properties characteristic is from 0 to 255, while the specification states it should be within -128 to 127 range.

Is that implementation intentional or is that a mistake?

For the reference see 3.2. Gain Setting Properties and Table 3.6: Set Gain Setting format

[barbibulle]

I think you're right. I also notice that the API for AudioInputState isn't quite right (the def increment_gain_settings(self, gain_settings_unit: int) -> None method shouldn't need a gain_settings_unit argument.
As to the Gain Setting Properties gain_setting_minimum and ``gain_setting_maximumas well as theAudio Input State` `gain_setting`, they should all be 8-bit signed values.
I can make the change in a PR shortly (I have a pending change that needs to land first, so as to avoid a conflict).