This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Additional metric support for HTTP probe #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config proto update EventMetrics per response body
mfboulos
force-pushed
the
feature/http-probe-metrics
branch
from
54cd061 to
c64b237
Compare
|
@manugarg Not sure if you've taken a look at this PR yet, just want to remind you that it's open |
|
Thanks for the reminder @mfboulos. It had slipped my mind. I'll take a look soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297.
I essentially added a couple options to the config proto for the http probe, which allow it to specify a bool
export_response_as_metricsto flag for reading the http response as metrics along withoutput_metrics_optionssimilar to the external probe.This forced a rename of the original
export_response_as_metricstoexport_response_count_as_metric, which makes a lot more sense given that the latter actually defines what is going on with that option.Another caveat here is that the
responseMetricsfield withinhttp.probeResultexposes theEventMetricsafter each http message, which may contradict the usual pattern of only sending event metrics toprobe.dataChanwhen the run count is a multiple of the run frequency.Otherwise, I also added a small check in
TestProbeWithBodyand it passed, so hopefully all looks good.