Detect premature use of @Inject properties with Android Lint

[jzbrooks]

Hilt rewrites methods to inject android components at a certain point (early) in their lifecycles, so premature access of @Inject properties will usually result in a kotlin.UninitializedPropertyAccessException or an NRE in Java. https://dagger.dev/hilt/components#component-lifetimes

For example, if a Fragment references an @Inject property in its initializer (or implicitly does so by using it to initialize another property), the app will crash.

[jzbrooks]

We might put this rule in Faithlife/AndroidLint#18, but thought it would be worth considering upstreaming.

[Chang-Eric]

Thanks for the suggestion! I think this Lint check is a good idea and I think it would make sense for something like this to be in Hilt. However, due to our current priorities, I'm not sure we're going to have time to take this PR right now, so I think maybe the best thing to do would be to put this rule into your project first and then we can look at upstreaming it into Hilt later in the future?

I'll leave this open as a feature request until then, but just wanted to be upfront about what we're able to take on right now. Thanks!