Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from 1.54.3 -> 1.56.1 only closest light is shown? #8296

Open
poweifeng opened this issue Dec 3, 2024 · 6 comments
Open

Moving from 1.54.3 -> 1.56.1 only closest light is shown? #8296

poweifeng opened this issue Dec 3, 2024 · 6 comments
Assignees
Labels
linux Issue/feature request for Linux only vulkan Issues with the Vulkan backend

Comments

@poweifeng
Copy link
Contributor

Discussed in #8289

Originally posted by tcadanklefsen December 2, 2024
Hello,

Moving from 1.54.3->1.56.1 seems to have changed drawing to only show the closest light. Here's where I was at previously:

20241120_092802.mp4

and here's where I'm at now:

20241202_140206.mp4

Any thoughts on what might have changed and where I could start investigating?

@poweifeng
Copy link
Contributor Author

Noted in #8289, that

1.54.5 works, 1.55.0 does not - continuing to look.

This implies that this might be due to the descriptor set change.

@poweifeng
Copy link
Contributor Author

@tcadanklefsen, can you elaborate on which backend (gl or vulkan) and platform (linux e.g) you are running on?
And as mentioned in the discussion, if you can provide a small repro app, it'd greatly help us to debug.

@tcadanklefsen
Copy link

Thanks, this uses Vulkan backend. Right now this uses a dart+native code in a large open source project; so its not entirely a small repro ;/

https://github.com/toyota-connected/ivi-homescreen-plugins/tree/v2.0/plugins/filament_view
https://github.com/meta-flutter/playx-3d-scene/

This is tested on ubuntu 20 and fedora 41 (Fedora we've hit a couple other issues that we're looking into separately) - and setup is done through here: https://github.com/meta-flutter/workspace-automation/ (if you're wanting the large repro case).

I'll work on putting together a smaller repro case.

If there's anything you want me to try and edit in filament code base I can try over here and report back as well.

@tcadanklefsen
Copy link

Good news, I was able to get it to happen in the lightbulb sample without changing anything:

Building:

cmake ../ -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DFILAMENT_SUPPORTS_VULKAN=ON -DFILAMENT_ENABLE_LTO=ON -DFILAMENT_SUPPORTS_OPENGL=OFF -DFILAMENT_BUILD_SAMPLES=ON -DFILAMENT_SUPPORTS_WAYLAND=ON -DFILAMENT_SUPPORTS_X11=OFF -DFILAMENT_SUPPORTS_XCB=OFF -DCMAKE_BUILD_TYPE=Release

Running:

./lightbulb -d -p -a vulkan -m assets/models/monkey/monkey.obj

20241203_152815.mp4

@pixelflinger
Copy link
Collaborator

that's strange, I'm not seeing the problem on the mac + moltenvk.

do you see the same issue with -a opengl ?

@pixelflinger pixelflinger added vulkan Issues with the Vulkan backend linux Issue/feature request for Linux only labels Dec 5, 2024
@tcadanklefsen
Copy link

I'm assuming opengl + wayland isn't supported?

cmake ../ -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DFILAMENT_SUPPORTS_VULKAN=OFF -DFILAMENT_ENABLE_LTO=ON -DFILAMENT_SUPPORTS_OPENGL=ON -DFILAMENT_BUILD_SAMPLES=ON -DFILAMENT_SUPPORTS_WAYLAND=ON -DFILAMENT_SUPPORTS_X11=OFF -DFILAMENT_SUPPORTS_XCB=OFF -DCMAKE_BUILD_TYPE=Release

./lightbulb -d -p -a opengl -m assets/models/monkey/monkey.obj

Output:

FEngine (64 bits) created at 0x20b966e0 (threading is enabled)
FEngine resolved backend: OpenGL
Selected backend not supported in this build.
Segmentation fault (core dumped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux Issue/feature request for Linux only vulkan Issues with the Vulkan backend
Projects
None yet
Development

No branches or pull requests

3 participants