-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NNX documentation missing pooling operations #4271
Comments
Can you help find the source code @cgarciae |
Hey, Line 38 in 5d896bc
But the entire file uses only Lines 17 to 19 in 5d896bc
We should copy it to flax/core/nn/pooling.py in order to have have it in the new nnx API.We should also copy the pooling doc from https://github.com/google/flax/blob/main/docs/api_reference/flax.linen/layers.rst#pooling to a new file called docs_nnx/api_reference/flax.nnx/nn/pooling.rst to have up to date nnx documentation
If you agree with the changes, I can send a PR with them. |
@jorisSchaller happy to review the PR! |
The NNX API reference does not seem to have entries for pooling operations like
nnx.avg_pool
ornnx.max_pool
.The text was updated successfully, but these errors were encountered: