Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the x86 build/test from the CI. #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qinkunbao
Copy link
Collaborator

Remove the x86 build/test from the CI from the CI for the following reasons.

  1. Our CVMs only support x86-64.
  2. Some dependency libraries (go-tdx-guest, go-sev-guest) are only tested with x86-64.
  3. go-tpm-tools releases only have x86-64.

@JoshuaKrstic
Copy link
Contributor

/gcbrun

@jkl73
Copy link
Contributor

jkl73 commented Sep 23, 2024

CVM is not the only platform this tool/lib can run.
Majority features on gotpm cli and libs are not depending on go-tdx-guest/go-sev-guest
Users may still want to build the binary on a 32 bit system.

@jkl73
Copy link
Contributor

jkl73 commented Sep 24, 2024

So I think we probably should keep x86 build/test in CI, unless it's so broken and beyond fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants