Added goopack functions into goolib #91
Conversation
There was a problem hiding this comment.
There are a number of changed I'd like to suggest, but they're more suitable for follow-up pull requests. I will file them as issues instead, so they can be discussed.
For example, CreatePackage requires an input and output path. It would be preferable to have these arguments be an io.Reader and io.Writer instead. The current implementation of CreatePackage (and all the helpers) assume a local filesystem, which is not always the case.
Perhaps a more appropriate course of action instead of refactoring all the existing code, is to introduce "CreateRemotePackage", which implements a OS agnostic archive. For the use case I need, local filesystem doesn't work, as well as shelling out to different tools.
As far as this change, it looks good to me.
| firstGlob int | ||
| } | ||
|
|
||
| //CreatePackage accepts a goospec file and generates the packaged goo file |
added files
(the functions from goopack/goopack.go and test functions from goopack/goopack_test.go will be removed in the next PR)