Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneToN Dialect Conversion deprecated #1243

Open
ZenithalHourlyRate opened this issue Jan 7, 2025 · 2 comments
Open

OneToN Dialect Conversion deprecated #1243

ZenithalHourlyRate opened this issue Jan 7, 2025 · 2 comments
Assignees

Comments

@ZenithalHourlyRate
Copy link
Collaborator

The upstream MLIR one to N dialect conversion engine has been merged into the default dialect conversion engine, and all related methods for them have been marked as deprecated and will be deleted in April 2025.

Check https://discourse.llvm.org/t/rfc-merging-1-1-and-1-n-dialect-conversions/82513/10

Affected pass in HEIR: lib/Transforms/TensorToScalars/TensorToScalars.cpp

lib/Transforms/TensorToScalars/TensorToScalars.cpp:75:14: warning: 'replaceOp' is deprecated: Use replaceOpWithMultiple() instead [-Wdeprecated-declarations]
    rewriter.replaceOp(op, adaptor.getFlatOperands(),
             ^~~~~~~~~
             replaceOpWithMultiple
lib/Transforms/TensorToScalars/TensorToScalars.cpp:148:28: warning: 'applyPartialOneToNConversion' is deprecated: Use applyPartialConversion() instead [-Wdeprecated-declarations]
    if (mlir::failed(mlir::applyPartialOneToNConversion(
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                           applyPartialConversion

Cc @AlexanderViand-Intel

@AlexanderViand-Intel AlexanderViand-Intel self-assigned this Jan 7, 2025
@j2kun
Copy link
Collaborator

j2kun commented Jan 8, 2025

We can eagerly fix this, but also part of the benefit of Google ownership is that the Google-internal oncall rotation that will handle any breakages, or at worst disable failing tests, so long as the tests are exercising this section of code.

@AlexanderViand-Intel
Copy link
Collaborator

We can eagerly fix this, but also part of the benefit of Google ownership is that the Google-internal oncall rotation that will handle any breakages, or at worst disable failing tests, so long as the tests are exercising this section of code.

Good point! The TensorToScalars pass is only used at the end of the HEIR-to-HERACLES pipeline to remove tensor types and extract/inserts from polynomial/modarith-level IRs (since the HERACLES SDK doesn't have a concept of tensors of polynomials), so it's not exactly "critical" and I'd be happy to see how it's handled and only step in if needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants