You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The upstream MLIR one to N dialect conversion engine has been merged into the default dialect conversion engine, and all related methods for them have been marked as deprecated and will be deleted in April 2025.
We can eagerly fix this, but also part of the benefit of Google ownership is that the Google-internal oncall rotation that will handle any breakages, or at worst disable failing tests, so long as the tests are exercising this section of code.
We can eagerly fix this, but also part of the benefit of Google ownership is that the Google-internal oncall rotation that will handle any breakages, or at worst disable failing tests, so long as the tests are exercising this section of code.
Good point! The TensorToScalars pass is only used at the end of the HEIR-to-HERACLES pipeline to remove tensor types and extract/inserts from polynomial/modarith-level IRs (since the HERACLES SDK doesn't have a concept of tensors of polynomials), so it's not exactly "critical" and I'd be happy to see how it's handled and only step in if needed :)
The upstream MLIR one to N dialect conversion engine has been merged into the default dialect conversion engine, and all related methods for them have been marked as deprecated and will be deleted in April 2025.
Check https://discourse.llvm.org/t/rfc-merging-1-1-and-1-n-dialect-conversions/82513/10
Affected pass in HEIR:
lib/Transforms/TensorToScalars/TensorToScalars.cpp
Cc @AlexanderViand-Intel
The text was updated successfully, but these errors were encountered: