Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Cosmetic) kt_shadow_clear is dead code and seems broken #212

Open
kimgr opened this issue Mar 5, 2018 · 1 comment
Open

(Cosmetic) kt_shadow_clear is dead code and seems broken #212

kimgr opened this issue Mar 5, 2018 · 1 comment
Labels
KTSAN KTSAN-related issues wontfix

Comments

@kimgr
Copy link

kimgr commented Mar 5, 2018

kt_shadow_clear appears to be getting the end of the shadow region wrong:

void kt_shadow_clear(uptr_t addr, size_t size)
{
	void *shadow_beg;
	void *shadow_end;
	size_t shadow_size;

	shadow_beg = kt_shadow_get(addr);
	shadow_end = kt_shadow_get(addr);

I'm guessing it should say something like shadow_end = shadow_begin + size; or shadow_end = kt_shadow_get(addr + size); instead. But in either case it's never called, so maybe just scrap it?

@dvyukov
Copy link
Collaborator

dvyukov commented Mar 6, 2018

Hi @kimgr,

I guess we need to drop it if it's unused.
This code is currently on hold, we will take care of this when we revive work on KTSAN.

Thanks

@xairy xairy transferred this issue from google/ktsan Dec 23, 2021
@xairy xairy added the KTSAN KTSAN-related issues label Dec 23, 2021
@melver melver added the wontfix label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KTSAN KTSAN-related issues wontfix
Projects
None yet
Development

No branches or pull requests

4 participants