-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Method: get_paid_media_channels_argument_builder()
Not Found in meridian.input_data
#544
Comments
Hi, We updated the documentation in tandem with commit 4521db1 that we pushed yesterday. However, it has not been published to PyPI yet. If you had installed Meridian with Some workarounds:
I'm not sure what you meant by using "InputData class as a workaround, it forces a geographic hierarchy model, which is not suitable for my use case as I am working on a national model without a geo dimension." You should be able to create an |
You can bypass the requirement of from meridian.data import arg_builder
build_media_channel_args = arg_builder.OrderedListArgumentBuilder([
'Channel1',
'Channel2',
'Channel3',
'Channel4',
'Channel5',
'Channel6'
])
# The rest is the same as the code snippet in https://developers.devsite.corp.google.com/meridian/docs/user-guide/configure-model
However, this also requires the latest Meridian code at HEAD. If you're still working with roi_m_mu = [0.2, 0.3, 0.4, 0.3, 0.3, 0.4] # must match media channel ordering in InputData
roi_m_sigma = [0.7, 0.9, 0.6, 0.7, 0.6, 0.5] # must match media channel ordering in InputData
prior = prior_distribution.PriorDistribution(
roi_m=tfp.distributions.LogNormal(
roi_m_mu, roi_m_sigma, name=constants.ROI_M
)
) |
🔍 Issue Summary
The function
get_paid_media_channels_argument_builder()
is referenced in the Meridian documentation, but it does not exist inmeridian.input_data
. This causes anAttributeError
when trying to call it as shown in the official documentation. Additionally, when attempting to use theInputData
class as a workaround, it forces a geographic hierarchy model, which is not suitable for my use case as I am working on a national model without ageo
dimension.📌 Expected Behavior
meridian.input_data.get_paid_media_channels_argument_builder()
should exist and return an argument builder for paid media channels.InputData
and geographic dimensions.🐛 Observed Behavior
Calling:
Results in the error:
Attempting to use the
InputData
class to access the method forces me to providegeo
, which does not apply to my national model setup.🔗 References
🙏 Request
Could you confirm whether
get_paid_media_channels_argument_builder()
is supposed to work without requiringInputData
, or if an alternative exists for national models that do not include ageo
dimension? If this is a bug, please clarify how national models should handle media channel arguments. Thanks for your help! 🙌The text was updated successfully, but these errors were encountered: