Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add test harness for cli invocation with file resolution cases #1479

Open
noahdietz opened this issue Feb 19, 2025 · 0 comments
Open

cli: add test harness for cli invocation with file resolution cases #1479

noahdietz opened this issue Feb 19, 2025 · 0 comments

Comments

@noahdietz
Copy link
Collaborator

We need to come up with a test harness for CLI invocations of api-linter. While fixing #1465 I didn't cover two edge cases effectively with local manual testing. A lot of the complexity comes from setting up protoparse APIs, ResolveFilenames and Parse, to properly resolve things with the given input, combined with a large set of possible combinations that callers can come up with.

Ideally, we have a a much more robust cmd/api-linter/cli_test.go with a lot more test data, with imported protos, and changing process directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant