Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating with stackdriver leads to dependency hell #6203

Open
igorbernstein2 opened this issue Aug 30, 2019 · 2 comments
Open

Integrating with stackdriver leads to dependency hell #6203

igorbernstein2 opened this issue Aug 30, 2019 · 2 comments
Labels
dependencies priority: p4 type: process A process-related concern. May include testing, release, or the like.

Comments

@igorbernstein2
Copy link

This issue falls somewhere between google-cloud-java clients, stackdriver and the oss bom. It doesn't seem like there is consensus on how to deal with this issue. So I'll start the discussion here and we can move it else where.

As it stands it's really not easy for customers to get dependencies right when trying to integrate a google-cloud-java client with an opencensus stackdriver exporter.

Issue 1: google-cloud-java clients only depend on opencensus-api, to enable metrics they need to add at least 2 more dependencies: opencensus-impl and an exporter. Which means customers will need to manually track the version opencensus used by google-cloud-java and bump their versions of opencensus-impl and an exporter. I spoke to @chingor13 about this and he thought this should be in the oss bom. But it seems like there is some push back: GoogleCloudPlatform/cloud-opensource-java#862

Issue 2: since the stackdriver exporters use google-cloud-java clients, they will always have older versions grpc & friends. Which requires customers to either exclude common deps from the stack driver exporters or import the grpc bom and then manually bump versions to stay in sync with google-cloud-java's grpc bom

/cc @elharo @chingor13 @suztomo @kolea2

@elharo
Copy link
Contributor

elharo commented Aug 30, 2019

Which libraries do you mean by google-cloud-java clients? Somehting in this repo or something that uses this repo?

@igorbernstein2
Copy link
Author

In this repo. Specifically bigtable: #6143

But it also applies to other clients in this repo that don't have explicit integration with opencensus. It would be very useful for customers to be able to export underlying grpc metrics to stack driver.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Aug 31, 2019
@chingor13 chingor13 added dependencies type: process A process-related concern. May include testing, release, or the like. labels Sep 3, 2019
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies priority: p4 type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

5 participants