Update new-client.py to set transport
based on Bazel
#8747
Labels
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Is your feature request related to a problem? Please describe.
new-client.py generates the
repo-metadata.json
file with thetransport
option set togrpc
was default. This can lead to discrepancies betweenrepo-metadata.json
and theBUILD.bazel
file which is technically the source of truth.For instance, for
java-api-gateway
: therepo-metadata.json
file showstransport: grpc
: https://github.com/googleapis/java-api-gateway/blob/main/.repo-metadata.json#L8, however theBUILD.bazel
file shows that actuallytransport: grpc+rest
: https://github.com/googleapis/googleapis/blob/master/google/cloud/apigateway/v1/BUILD.bazel#L96.This will not fix the issue where the
BUILD.bazel
file gets updated post initial library generation to a different transport; that can be addressed in a follow up.Describe the solution you'd like
new-client.py should generate the
transport
option based on theBUILD.bazel
file if possible.Alternatively, if there's a way to automatically update
repo-metadata.json
based on theBUILD.bazel
file in general, that could solve both new client generation and existing library updates.The text was updated successfully, but these errors were encountered: