Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update click(selector) and locator.click admonitions #1782

Open
heitortsergent opened this issue Oct 24, 2024 · 0 comments
Open

Update click(selector) and locator.click admonitions #1782

heitortsergent opened this issue Oct 24, 2024 · 0 comments
Assignees
Labels
Area: browser The browser module type/docs

Comments

@heitortsergent
Copy link
Collaborator

From user feedback, there are two admonitions we should update:

  • click(selector) - we have a warning at the top that says to use locator(click) instead, but doesn't explain why.
  • locator(click) - we have a caution that the method has known issues and include links, but we don't explain why as well.

We should update these admonitions to give more details to the user what we recommend and why, and any possible drawbacks.

This could also be a new best practices guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module type/docs
Projects
None yet
Development

No branches or pull requests

1 participant